Closed Bug 1062970 Opened 10 years ago Closed 9 years ago

Vagrant: Automatically re-compile the log parsers when *.pyx files are modified

Categories

(Tree Management :: Treeherder, defect, P4)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: emorley, Unassigned, Mentored)

Details

(Whiteboard: [good first bug][lang=python])

User Story

Thank you for helping out with Treeherder!

You can find us on IRC at irc://irc.mozilla.org/treeherder

Here's some links to help get you started.

Project page:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder

Interacting with us, repo locations and links to set up a development version of the software:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs

A-Team general reference, coding style guides:
http://ateam-bootcamp.readthedocs.org
I made changes to log_parser/parsers.pyx and yet on next run of |py.test tests/log_parser/test_log_view_artifact_builder.py| these didn't get picked up.

It took some time to realise what was going on, until I finally spotted the note on:
https://treeherder-service.readthedocs.org/en/latest/installation.html

{
The log parser shipped with treeherder makes use of cython. If you change something in the treeherder/log_parser folder, remember to re-build the c extensions with:
(venv)vagrant@precise32:~/treeherder-service$ python setup.py build_ext --inplace
}

If we could do this automatically it would be awesome :-)
(Service watching in the VM that builds on changes; like other reloader services?)

Or even just re-compiling when running the parser tests :-)
Blocks: 1072681
No longer blocks: 1072681
Component: Treeherder → Treeherder: Docs & Development
Priority: P3 → P4
Assignee: nobody → emorley
User Story: (updated)
Whiteboard: [good first bug]
Assignee: emorley → nobody
Mentor: emorley
Whiteboard: [good first bug] → [good first bug][lang=python]
User Story: (updated)
At the least we could re-compile as part of runtests.sh to make things easier for new contributors (re-compilation is fairly quick if the log parser files hadn't changed).
No longer applicable, since we've stopped using Cython (bug 1169916).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.