1062989 - Have separate localizable string for color filter label and heading

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eitan Isaacson [:eeejay]]

colorFilter needs to have a separate heading version, as all other labels in the app are.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23731

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8484309 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23731

I shouldn't really review patches, but this one seems trivial enough.

Thanks for fixing also the other title that I didn't notice.

Comment 3

[Francesco Lodolo [:flod]]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1049824#c55

We're actually reusing the string as a button inside the panel, so we should fix that too.

Comment 4

[Eitan Isaacson [:eeejay]]

Comment on attachment 8484309 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23731

OK. Added distinct strings for toggle buttons of color filter and screen reader as well.

Comment 5

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/1bfc67f0e3ef9ef3056f9607392fbb762ae69017

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8484309 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23731

I relied on flod's original review. This is a straightforward string change.

Comment 7

[Théo Chevalier]

Comment on attachment 8484309 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23731

Thanks for the patch Eitan :)
Asking for uplift to 2.1 now as string freeze is tomorrow.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1049824
[User impact] if declined: Not easily localizable strings for accessibility settings.
[Testing completed]: Flame 2.2
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: yes, 4 new strings in settings.properties

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 8484309 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23731

low risk , accessibility improvements.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/dcf16872b4447d03d414199908394abc3836633c