Use a modal consistently

RESOLVED WONTFIX

Status

P3
normal
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: delza, Unassigned)

Tracking

2014-Q2
x86
Mac OS X
Points:
---

Details

(Whiteboard: [marketplace-transition])

(Reporter)

Description

4 years ago
Our modals appear to be hand-rolled and each one has to have consistent HTML structure (repetitive), while updating them across the board can require a fair bit of duplicated work. Adopting a library for managing our modals could make all of these simpler and easier to maintain.
(Reporter)

Comment 1

4 years ago
Actually, we may have not one, but three (maybe more?) modal libraries, but we're not consistent about their use, as far as I can tell. We have modal code in Commonplace `navigation.js`, Fireplace `lightbox.js`, and in Fireplace `overlay.js`. We do use the overlay code, but sometimes have code which handles things like Cancel in a way that breaks the working default (i.e., https://bugzilla.mozilla.org/show_bug.cgi?id=997046). So perhaps we just need to standardize on one of these, document it's use, and remove the others. We could also move things like inserting the 'x' for dismissing the modal in automatically, to avoid issues like https://bugzilla.mozilla.org/show_bug.cgi?id=1062576 occuring.
(Reporter)

Updated

4 years ago
Summary: Use a modal library for consistency → Use a modal consistently
(Reporter)

Updated

4 years ago
Whiteboard: [repoman]

Updated

4 years ago
Priority: -- → P3
Whiteboard: [repoman]
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
You need to log in before you can comment on or make changes to this bug.