1063041 - Inline the activity options used in the SMS app in order to make it easier to automatically extract the activity arguments from the source code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[(no longer active)]

+++ This bug was initially created as a clone of Bug #1062564 +++

I'm working on a static analysis tool which can extract information about all MozActivity API usages from the gaia source code.  It's much simper for this tool if the activity options argument was passed as an inline JS object.  I have a simple patch which does this for the SMS app.

(I would be open to other approaches too BTW, I cannot think of a better one.)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Anthony Ricaud (:rik)]

Comment on attachment 8484374 [details] [review]
Patch (v1)

Redirecting because Julien is on PTO.

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8484374 [details] [review]
Patch (v1)

r=me with one nit on Github! 

Just a thought: IMO there is a chance that MozActivity usage in this particular case can be generalized once again in the future as it feels naturally from dev stand point. So if static analysis tool is not going to handle such "generalized" cases in the future, maybe we need explicit code comment about that :)

Thanks!

Comment 4

[(no longer active)]

Sure, that's a good idea.  I will add a comment there.

Comment 5

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/4abb193ddae0f9780ad12ffe5e31772feee3926a