Closed Bug 1063041 Opened 8 years ago Closed 8 years ago

Inline the activity options used in the SMS app in order to make it easier to automatically extract the activity arguments from the source code

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S4 (12sep)

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
azasypkin
: review+
Details | Review
+++ This bug was initially created as a clone of Bug #1062564 +++

I'm working on a static analysis tool which can extract information about all MozActivity API usages from the gaia source code.  It's much simper for this tool if the activity options argument was passed as an inline JS object.  I have a simple patch which does this for the SMS app.

(I would be open to other approaches too BTW, I cannot think of a better one.)
No longer depends on: 1062564
Attached file Patch (v1)
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #8484374 - Flags: review?(felash)
Component: Gaia::Dialer → Gaia::SMS
Comment on attachment 8484374 [details] [review]
Patch (v1)

Redirecting because Julien is on PTO.
Attachment #8484374 - Flags: review?(felash) → review?(azasypkin)
Comment on attachment 8484374 [details] [review]
Patch (v1)

r=me with one nit on Github! 

Just a thought: IMO there is a chance that MozActivity usage in this particular case can be generalized once again in the future as it feels naturally from dev stand point. So if static analysis tool is not going to handle such "generalized" cases in the future, maybe we need explicit code comment about that :)

Thanks!
Attachment #8484374 - Flags: review?(azasypkin) → review+
Sure, that's a good idea.  I will add a comment there.
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/4abb193ddae0f9780ad12ffe5e31772feee3926a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
You need to log in before you can comment on or make changes to this bug.