Directly Execute Bash Scripts in Makefile and Build.sh

RESOLVED FIXED

Status

Socorro
Infra
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bramwelt, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
In the Makefile and build.sh scripts are called using either `bash` or `source`. 

By using bash to call a script, any flags specified to the interpreter on the first line do not get set, and sourcing files was done historically because many scripts exported environment variables needed by further scripts.

Changing these to directly execute the scripts will allow for finer grain control over the flags used by each script, and bring back the verbose output some scripts specify
(Reporter)

Comment 1

3 years ago
https://github.com/mozilla/socorro/pull/2335

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d934e22d8b02826f224da3444cd578240c935d78
No longer invoke scripts using `bash` or `source`

This allows the bash arguments at the top of each script to be
respected.

fix bug 1063104

https://github.com/mozilla/socorro/commit/13ac9fd8eef1067854f5f52e0b3c6ae035365807
Make non-executable scripts executable.

fix bug 1063104

https://github.com/mozilla/socorro/commit/c8ea578c5ef312003d8051698d7ce7e2b66825b4
Merge pull request #2335 from bramwelt/fix-bug-1063104-directly-invoke-scripts

fix bug 1063104 - Directly invoke bash scripts in Makefile and build.sh
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.