Closed
Bug 1063106
Opened 10 years ago
Closed 10 years ago
[camera] rapid taps on the shutter button set focus region behind the button
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: djf, Assigned: justindarc)
Details
Attachments
(1 file)
If I tap once on the shutter button, it takes a picture and does not set the focus region.
But if I tap rapidly on it, then while the camera is busy taking a photo, subsequent taps set the focus region. I suspect that the button is being disabled so its event handler is not called and it does not call stopPropagation() on the tap event so it goes on to be handled by the focus event handler.
It is hard to see the focus region being set because the focus ring is underneath the shutter button, but if I tap slightly off center I can see it.
This is a bug for the user because they might accidentally set the focus region without realizing it, and then when they take another picture it would unexpectedly focus on the wrong thing.
The same thing happens for other controls on the screen. If I tap on the shutter button and then quickly tap on the mode switch button or the flash mode button, for example, the focus region moves.
I would suggest that the fundamental problem is that you have too many decoupled controller modules trying to handle the same events. If it was me, I'd refactor so that there was one module that was responsible for all touch events on the viewfinder.
Reporter | ||
Comment 1•10 years ago
|
||
Needinfo Diego and Justin so you're aware of this bug.
Flags: needinfo?(jdarcangelo)
Flags: needinfo?(dmarcos)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jdarcangelo
Flags: needinfo?(jdarcangelo)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8485866 -
Flags: review?(dmarcos)
Comment 3•10 years ago
|
||
Comment on attachment 8485866 [details] [review]
pull-request (master)
The proper way to fix that is that the controls view should always prevent propagation of events to the viewfinder. You should not be able to tap to focus in the region underneath the controls.
Attachment #8485866 -
Flags: review?(dmarcos) → review-
Flags: needinfo?(dmarcos)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8485866 [details] [review]
pull-request (master)
Addressed review comments. Please re-review, thanks!
Attachment #8485866 -
Flags: review- → review?(dmarcos)
Updated•10 years ago
|
Attachment #8485866 -
Flags: review?(dmarcos) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Landed on master:
https://github.com/mozilla-b2g/gaia/commit/17c9b1749861061854e41dea18a232f4ac15f357
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•