1063172 - Able to submit the same app multiple times to the low-memory review queue

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: duplicate apps.png

steps to reproduce:
1. Submit an app
2. Before setting up the Content Ratings, submit the app for low-memory support  a dozen times since clicking the button creates a 201 but keeps the button enabled.
3. Set up content ratings
4. Approve the app from the regular review queue
5. Load https://marketplace-dev.allizom.org/reviewers/apps/queue/additional/tarako

expected behavior:
Irrespective of when the app is submitted to the low-memory review queue, it should only get submitted once.

actual behavior:
App can be submitted multiple times
Same app gets listed multiple times in the review queue

Comment 1

[Mark Striemer [:mstriemer]]

Good catch. This one was a little weird.

Two bugs: the check to limit pending reviews was only checking apps that were approved/public, and the link to the status page put an anchor in the URL so `window.location = window.location` would take you back to the anchor instead of refreshing the page.

https://github.com/mozilla/zamboni/pull/2509

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/4c629414489d7180ef2c94d52236ccd913351790

Comment 3

[Victor Carciu]

Verified as fixed . We are not able to request many tarako reviews because the button is not available anymore after first request.