1063249 - [Search] When user types "Http:" into the Rocketbar and taps search/enter the keyboard closes and browser opens in background

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
Tapping Rocketbar on homescreen and type "Http:" in search bar, then pressing enter/search closes the keyboard. A background process opens a browser window displaying a "URL not valid" error. User cannot see this page unless they switch to it in task manager card view.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140904000203
2) Tap rocketbar
3) Type "Http:" in search
4) Select magnifying glass icon on keyboard to search
  
Actual:
The keyboard closes and browser opens in background
  
Expected: 
Error about URL not being valid is displayed in foreground to user
  
Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140904000203
Gaia: a47ecb6368c015dd72148acde26413fd90ba3136
Gecko: 757931d0149e
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
  
Repro frequency: 3/3, 100%
See attached: Youtube video & logcat
Youtube link: http://youtu.be/G5NWgVJdai4

Comment 1

[Brogan Zumwalt [Inactive]]

QA Wanted added for branch checks

Comment 2

[Brogan Zumwalt [Inactive]]

Issue DOES occur on Flame 2.2 (319mb), OpenC 2.2, Flame 2.1 (512mb), and OpenC 2.1

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140904040204
Gaia: 008026e932b64b4a70b9931c3da96986583bc8d4
Gecko: 776fa9cf70cd
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Environmental Variables:
Device: Open_C Master
Build ID: 20140904040204
Gaia: 008026e932b64b4a70b9931c3da96986583bc8d4
Gecko: 776fa9cf70cd
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Environmental Variables:
Device: Flame 2.1 (512mb)
BuildID: 20140904000203
Gaia: a47ecb6368c015dd72148acde26413fd90ba3136
Gecko: 757931d0149e
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Open_C 2.1
BuildID: 20140904000203
Gaia: a47ecb6368c015dd72148acde26413fd90ba3136
Gecko: 757931d0149e
Version: 34.0a2 (2.1)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Actual Results: The keyboard closes and browser opens in background


Issue does NOT occur on Flame 2.0 (319mb) & OpenC 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140904000202
Gaia: d056733f8a7a1a152f5458b323f092c47dbffa48
Gecko: 19383abee78a
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C 2.0 
Build ID: 20140904000202
Gaia: d056733f8a7a1a152f5458b323f092c47dbffa48
Gecko: 19383abee78a
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Actual Results: On 2.0 no browser window opens (in background or otherwise), keyboard just closes.


Rocketbar not implemented in 1.4. Unable to test/reproduce on this build.

Comment 3

[Brogan Zumwalt [Inactive]]

Correction: 2.1 Flame and OpenC User Agent for comment 0 and comment 1 should read "User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"

Comment 4

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Not blocking on this issue. This does not seem like something users will often search, this can also be worked around by searching "app:" on a search engine

Comment 5

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Comment 4 should say "http:" instead of "app:"

Comment 6

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Fix searching 'http:' or 'app:' in rocketbar, this patch could also fix bug 1063231

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8487030 [details] [review]
Pull request

Seems to work for me, thanks!

Comment 8

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/085c3d97efadd796f58c2f4443ae4c432a652dc0

Comment 10

[vsireesha246]

Please find the below another STR for this issue in V2.0

1.Open browser app and search any word with :(colon) at the end of the word(For example ffos:)
2.Browser unable to search the word entered
3.But Home screen searchbar able to search the same word

After applying this patch(https://github.com/mozilla-b2g/gaia/commit/085c3d97efadd796f58c2f4443ae4c432a652dc0) in V2.0 its works fine.