Closed Bug 106325 Opened 23 years ago Closed 22 years ago

Drag bookmarks into folders

Categories

(SeaMonkey :: Bookmarks & History, enhancement)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: trudelle, Assigned: bugzilla)

References

Details

(Whiteboard: [ADT2 rtm])

Attachments

(1 file)

missed xpfe/browser/resources/content changes.
10.96 KB, patch
bugs
: superreview+
Details | Diff | Splinter Review 
This is a feature tracking bug for the ability to file into specific location
within folders in popup menus. This is pretty strange UI but some Windows users
are used to it, and expect us to go the next step. Blake is reportedly working
on it at the moment.  Need estimate of task duration.
Blocks: 102472
Bugs this might depend on:

bug 18052 Ability to D&D the proxy icon into the bookmarks menu or submenu 
bug 96504 [linux] after dragging proxy icon onto bookmarks button, bookmarks 
menu refuses to close
bug 50505 d&d bookmarks in menu
bug 41888 [RFE] Quickfile: 'File' bookmarks to cascading submenus, to file in 
folders (on the fly) 
bug 19437 [RFE] Move, delete, and edit bookmarks inline (in menu)
bug 50504 Context menu for bookmarks menus
bug 100479 Dragging link over Personal Toolbar folder should open menu
Keywords: meta
What's the target and priority for this bug? Are we planning to have this done
for MachV?

--> Trudelle for reassignement
Assignee: pchen → trudelle
->ben
Assignee: trudelle → ben
This is currently not on my set of assigned features, so I'm assuming it has
been cut.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
No, it hasn't been cut, and you haven't identified it as being at risk.  Is it?
Target Milestone: Future → ---
blake said he'd take this
Assignee: ben → blaker
Status: ASSIGNED → NEW
Cool!,  but it has to be done in ->099, or made a candidate for cutting now.
Target Milestone: --- → mozilla0.9.9
actually this worked fine before bookmarks-outliner landed, there are several
bugs about this feature being broken, dragging between folders, bookmarks list,
from url bar to personal toolbar folders, etc.
that is what is bug is about is it not?
Keywords: meta
No, this is about dragging bookmarks into folders on the personal toolbar.  It
will get done for 099 as I have a patch.

I will note, however, that as of now this works in the same way as it does for
the bookmarks button: you can't currently drop into a specific location of a
nested folder.

That is, given

[ Button ]
 [ Bookmark 1 ]
 [  Folder 1  ]  > [ Bookmark 2 ]
                   [  Folder 2  ]

Folder 2 will not expand to allow specific placement (however, you can drop on
it to append it to the end -- the folder icon opens and the item highlights to
indicate this.)

This was originally deemed okay for a first-cut implementation because most
users presumably don't have such nested folders, and because anything more
complicated -- trying to keep track of the open nested folders -- would probably
be buggy at best.

If it's deemed a priority that nested folder opening work as well, I can
certainly post a patch, but I think it's even less important for this bug. I
don't consider a folder within a folder within a personal toolbar folder the
common usage scenario (a folder within a personal toolbar folder will open as
expected).
Status: NEW → ASSIGNED
I think you're exactly right Blake; even my worst-case Bookmark folder doesn't
have that scenario.  IMO, it is not worth handling, though if someone wanted to
contribute a rock-solid patch for it, that might be worth considering.
Keywords: nsbeta1
this is fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
 Arg? Are you sure? It doesn't work on my win32 build from Feb. 21. Isn't this
bug for expanding personal toolbar folders when one drags a link over them, and
letting the user place the bookmark in a particular place in that folder (like
the windows98 and later start menu)?
Hi, this still doesn't work on Feb. 25 builds.  I see no patch attached to this
bug.  I really think it is a mistake to mark this fixed.
Keywords: nsbeta1+
From Blake's comment 10, I'd say this is a dup of bug 100479.
reopening, this bug as reported is not fixed in linux build 2002 02 25 08
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Odd...works in my homegrown build. I'll look into this later, on my way out.
Status: REOPENED → ASSIGNED
Keywords: nsbeta1
Target Milestone: mozilla0.9.9 → mozilla1.0
Comment on attachment 72890 [details] [diff] [review]
missed xpfe/browser/resources/content changes.

sr=ben@netscape.com
Attachment #72890 - Flags: superreview+
Pierre, give it another go; this should work now.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
verified fixed on windows build 2002 03 16 03
I filed bug 133600, 133602 and 133604 for the remaining issues and especially
bug 133601 and bug 133621.

However I can not verify this bug with linux build 2002032608, since the
behavior is horked: 
- no feedback line
- DND does not seem to perform
- there is a persistent DND cursor icon above th menu
- and once, I could not close the folder menu (same as bug 96504 still waiting
for reviews) 
I don't know what is the best thing to do: reopening this bug or file some pp
linux bugs.
*** Bug 135091 has been marked as a duplicate of this bug. ***
Sorry about the duplicate report, it's pretty hard to tell what is what without
being familiar with the component. 
I just got build 2002031104
I still cannot drag links onto the toolbar icons and have them open. The link
goes to the bottom of the list in the toolbar icon, cannot be placed in a
folder, etc. in this build.  Works the same as the older build I was using. 
So in windows 98, not fixed. 
Works for me on win98.  Try getting a more recent build, 0311 is more than half
a month old!
The weird thing is, I got that build from the stub installer last night, off the
FTP. 
Wonder how that could have happened.  I am looking for a newer build now. 
thanks for the excellent QA work pierre (comment 21)

I wanted to mark this bug verified and simply go forward with the other 'small'
bugs, but it's a disgrace to fixed bugs to call this one fixed as well.

4 seconds of testing shows numerous errors with this feature on a Win98
2002041003 trunk build.(I just tried to drag the url proxy icon to a folder via
the bookmarks button on the toolbar and couldn't)

Did trying to cover the case in comment 10 lead to introducing all these bugs?

at this stage in the game I only see three options with the following cons:

1. Leave things as is and ship with obvious, broken, and quirky behavior.(even
worse on OSX for me)
  -obvious ramifications 

2. Try to fix all of these little bugs.
  -probably risky to muck around with XPMenus at this point. Plus, will likely
involve several iterations until we hit a 'good enough' point.

3. Rollback the most recent changes and pare down the functionality.
  -probably only slightly less risky than (2)

I'd be pleased to know if there is another answer.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
ADT2.  cc ben & bryner for possible help on this.
Whiteboard: [ADT2]
Huh???  Please point out the specific bugs you see. I don't see any of the
problems Pierre points out.  And dragging and dropping the proxy icon works fine
for me, unless I already have a bookmark to that url, in which case it does
nothing (there's nothing I can do about that, it's a bookmarks problem).
Okay, I see that the issues Pierre listed are pp Linux.  I thought we had
disabled this feature on Linux long ago because of issues with that platform. If
not, that is an easy fix, if we want to.

I also see that he linked to a few Windows bugs. The most important of them
seems to be that dragging over multiple folders in the personal toolbar opens
them.  That is simple to fix -- but that doesn't seem to be what you're
complaining about.

None of this has to do with XP menu code.
As I see it the issue with bookmarks and windows is this: You cannot drag a 
link into a folder on the personal toolbar, except to just drop it onto the 
folder. Iis then at the end of the list on that folder.  There is no real way 
to get it anywhere except at the end.  There could be organized folders in 
there, but you can't put a link into one. You gotta go in and rearrange it. 

Even dragging a link into the bookmarks list (crtl-B) is difficult because as 
soon as you click the link in the browser URL bar the bookmarks window goes to 
back. In netscape 4.7 this does not occur. 
Steve, are you using a nightly build or a milestone?
I am using last night's nightly build. Which has stuff broken which was fixed 
last week.  Heh. 
The worst thing I see is the folder/menus not closing on mouseOut, which bites
me several times a day when I overshoot dragging to a tab. I'm using NS
2002041011 on Win2K.  Is there a separate bug on that?  We should get separate
defects into their own bug reports.
trudelle: the bug you are seeing is bug 133601 (onDragOver) and bug 133621
(after onDrop). See the dependencies in bug 133604 for the other issues.
Btw, I tested this feature on Linux with the patch from bug 96504: all the good
and all the bad were similar to the Windows builds. No more, no less.
Worksforme. 
Windows 98 build 2002041103
I drag a link from the url bar to the toolbar icons, and they open, revealing
their folders, etc. Perfect!  

However, the ctrl-b bookmark window still pops to back if I click on the link
icon in the browser window.  Unlike 4.77
*** Bug 138159 has been marked as a duplicate of this bug. ***
Well, I'm re-resolving this FIXED since I have nsbeta1+ bugs on the most
important and reproducible issues.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Whiteboard: [ADT2] → [ADT2 rtm]
rs vrfy --able to d'n'd proxy icon to bookmarks folder in PT.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: