106326 - Better handling of IE favorites

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, enhancement, P2)

Description

[Peter Trudelle]

IE Favorites confuses users because their currently "read only" bookmarks as
opposed to "first class" bookmarks. Time estimate is 5 days.

Comment 1

[Peter Trudelle]

marking p2, mozilla0.9.7, and blocking 75643

Comment 2

[Matthias Versen [:Matti]]

related bugs: bug 56765 (wontfix), bug 68858 and bug 101174

Comment 3

[Jesse Ruderman]

What is this bug for?  The summary is very vague, and "IE Favorites confuses 
users because their currently 'read only' bookmarks as opposed to 'first class' 
bookmarks" could mean any of at least three things:

1. Users should be able to edit c:\windows\favorites\ from within Mozilla (bug 
56765).
2. Mozilla should actually import favorites instead of just displaying them 
(bug 59636).
3. IE favorites should look more read-only to avoid confusing users (bug 68858, 
bug 101174).

Is this a dup of one of those bugs, or is it something else that I didn't think 
of?

Comment 4

[Peter Trudelle]

It is a tracking bug for scheduled Navigator tasks to better handle IE
favorites.  I think the planned approach will satisfy bug 59636, but I don't
think it needs to be resolved as a dup.

Ben's engineering plan is: "permanent import: 5 days (including UI) - import
dialog, importing .lnk  files and creating new bookmarks, maintain ability to
show live view."

Comment 5

[Paul Chen]

Pushing out to mozilla0.9.8

Comment 6

[Peter Trudelle]

->ben

Comment 7

[Jaime Rodriguez, Jr.]

what are the chances this will make 098?

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

-> .9.9

Comment 9

[Andrew Hagen]

I apologize for any rudeness, but this doesn't look like a tracking bug. The
component is currently "Bookmarks." In addition, there are no bugs that this bug
depends on. That said, this bug doesn't have a clear write-up. I admit that I am
frequently and woefully ignorant, but could someone give a description of what
bug this is a report of? What is the expected behavior? TIA.

Comment 10

[Peter Trudelle]

Andrew: This is for tracking feature work, not a defect. It is distinct from
normal defect bugs, or meta bugs or bugs which have dependencies.  You are right
about its still being too undefined.  It needs a clear write-up for expected
behavior.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

hoboy. This patch includes extensive modifications to nsIBookmarksService to
tidy up the API, providing new helper methods for creating bookmarks and
folders. 

Also included are modifications which make the service do a one-off import of
system bookmarks on Mac and Windows into actual bookmarks and folders.

Comment 12

[Robert John Churchill]

Various small nits:

o  createBookmarkEx() and createFolderEx() are vaguely named and beg for better
names

o  please break lines similiar to the following (there are several spots) onto
two separate lines:
      +  nsAutoString bookmarkName; bookmarkName.Assign(aName);

o  now that bug # 124322 has been fixed, bookmark types (nodes and folders but
NOT separators or IE types) are now synthesized instead of stored internally in
the graph, so the following can be removed:
      +  // Resource: type
      +  rv = mInner->Assert(bookmarkResource, kRDF_type,
              kNC_Bookmark, PR_TRUE);

o  to add with debugging (when setting breakpoints), please change from this style:
      +  if (NS_FAILED(rv)) return rv;
   to this style:
      +  if (NS_FAILED(rv))
      +      return rv;

o  Should expose the pref in the Prefs UI for Win & Mac users

o  HasArcIn() and HasArcOut() can be called a lot, and it looks like for Windows
it now calls IsContainer() for the systemroot. A small optimization you can make
it to have it call IsSeq() instead.

Fix the above, and r=rjc

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. 

Comment 14

[Claudius Gayle]

VERIFIED Fixed with 20020409 builds

Comment 15

[Tony Tovar]

Since bug 59636 also blocks bug 120814 (meta), it's redundant (circular?) for
this bug to block both of them.  So, I'm removing bug 59636 from the blocker
list on this bug.

Since meta bug 102472 is specific to Netscape 6.x, it can "stay" blocked by this
FIXED bug.