1063271 - Global selection in NS_ScriptErrorReporter isn't quite right

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

I screwed this up in bug 796938 part 10. The specific case that isn't handled here is when the most-recent AutoJSAPI was initialized with InitWithLegacyErrorReporting. In that case, the stack-top cx that we were using before won't match the entry that we pull off of the script settings stack.

The easiest thing to do is just to back that part out (in an elegant manner to avoid reindentation churn). This will all get fixed up in bug 981187, which is coming very soon down the pipe.

Note - We should backport fix to Aurora.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Undo bug 796938 part 10. v1

Comment 2

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=ff63e801de9f

Comment 3

[Bobby Holley (:bholley)]

[Tracking Requested - why for this release]:

Potential regression from bug 796938. Just going to back that part out.

Comment 4

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=54916bb07ce0

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Bobby Holley (:bholley) from comment #0)
> I screwed this up in bug 796938 part 10. The specific case that isn't
> handled here is when the most-recent AutoJSAPI was initialized with
> InitWithLegacyErrorReporting. In that case, the stack-top cx that we were
> using before won't match the entry that we pull off of the script settings
> stack.
Huh.

Comment 6

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a8b6905a24a

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8484685 [details] [diff] [review]
Undo bug 796938 part 10. v1

Approval Request Comment
[Feature/regressing bug #]: bug 796938
[User impact if declined]: Errors might be reported in the wrong place in certain edge cases.
[Describe test coverage new/current, TBPL]: None. This is a backout.
[Risks and why]: Extremely low. This is a backout.
[String/UUID change made/needed]: None.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a8b6905a24a

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8484685 [details] [diff] [review]
Undo bug 796938 part 10. v1

Aurora+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f11b0d2a9e8