Global selection in NS_ScriptErrorReporter isn't quite right

RESOLVED FIXED in Firefox 34

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla35
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox32 unaffected, firefox33 unaffected, firefox34+ fixed, firefox35 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I screwed this up in bug 796938 part 10. The specific case that isn't handled here is when the most-recent AutoJSAPI was initialized with InitWithLegacyErrorReporting. In that case, the stack-top cx that we were using before won't match the entry that we pull off of the script settings stack.

The easiest thing to do is just to back that part out (in an elegant manner to avoid reindentation churn). This will all get fixed up in bug 981187, which is coming very soon down the pipe.

Note - We should backport fix to Aurora.
(Assignee)

Updated

4 years ago
Blocks: 1062631
(Assignee)

Comment 1

4 years ago
Created attachment 8484685 [details] [diff] [review]
Undo bug 796938 part 10. v1
Attachment #8484685 - Flags: review?(bugs)
(Assignee)

Comment 3

4 years ago
[Tracking Requested - why for this release]:

Potential regression from bug 796938. Just going to back that part out.
tracking-firefox34: --- → ?

Comment 5

4 years ago
(In reply to Bobby Holley (:bholley) from comment #0)
> I screwed this up in bug 796938 part 10. The specific case that isn't
> handled here is when the most-recent AutoJSAPI was initialized with
> InitWithLegacyErrorReporting. In that case, the stack-top cx that we were
> using before won't match the entry that we pull off of the script settings
> stack.
Huh.

Updated

4 years ago
Attachment #8484685 - Flags: review?(bugs) → review+
(Assignee)

Comment 7

4 years ago
Comment on attachment 8484685 [details] [diff] [review]
Undo bug 796938 part 10. v1

Approval Request Comment
[Feature/regressing bug #]: bug 796938
[User impact if declined]: Errors might be reported in the wrong place in certain edge cases.
[Describe test coverage new/current, TBPL]: None. This is a backout.
[Risks and why]: Extremely low. This is a backout.
[String/UUID change made/needed]: None.
Attachment #8484685 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9a8b6905a24a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
status-firefox32: --- → unaffected
status-firefox33: --- → unaffected
status-firefox34: --- → affected
status-firefox35: --- → fixed
tracking-firefox34: ? → +
Comment on attachment 8484685 [details] [diff] [review]
Undo bug 796938 part 10. v1

Aurora+
Attachment #8484685 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.