Refactor MSE tests, introduce mediasource.js shared functions

RESOLVED FIXED in mozilla35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

unspecified
mozilla35
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8484774 [details] [diff] [review]
Refactor MSE tests, introduce mediasource.js shared functions.
(Assignee)

Comment 3

4 years ago
Comment on attachment 8484774 [details] [diff] [review]
Refactor MSE tests, introduce mediasource.js shared functions.

The initial tests I added were dupes of test_MediaSource and contained a lot of unnecessary tests, plus duplicate code.  This makes the situation a fair bit nicer; there's probably more than can be shared, but we'll see as we add more tests.

Not sure if test-only changes really need a review, but an extra set of eyes can't hurt.
Attachment #8484774 - Flags: review?(cajbir.bugzilla)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8484774 [details] [diff] [review]
Refactor MSE tests, introduce mediasource.js shared functions.

Oops, I updated the test <title>s when I landed my last patch, but hadn't picked that change up in my dev repo.  New patch coming up.
Attachment #8484774 - Attachment is obsolete: true
Attachment #8484774 - Flags: review?(cajbir.bugzilla)
(Assignee)

Comment 5

4 years ago
Created attachment 8484780 [details] [diff] [review]
Refactor MSE tests, introduce mediasource.js shared functions.
Attachment #8484780 - Flags: review?(cajbir.bugzilla)

Comment 6

4 years ago
I noticed when porting a test to work on Chrome that I couldn't just appendBuffer or endOfStream, I had to do these in the 'updateend' or 'update' callback due to operations in progress. To faciliate easy testing across multiple browsers what do you think about doing that?

Comment 7

4 years ago
(In reply to cajbir (:cajbir) from comment #6)
> I noticed when porting a test to work on Chrome that I couldn't just
> appendBuffer or endOfStream, I had to do these in the 'updateend' or
> 'update' callback due to operations in progress. To faciliate easy testing
> across multiple browsers what do you think about doing that?

The other Chrome difference was needing to request the VP9 codec in in addSourceBuffer.
(Assignee)

Comment 8

4 years ago
Having the ability to run these tests in multiple UAs would be great, so I'm in favour of any changes to allow that.  We also need to be careful to balance writing tests now versus duplicating effort where we can use/import existing tests (such as bug 881514 and bug 996368) with more up-front work but a larger payoff in terms of test coverage and cross-UA testing.
(Assignee)

Updated

4 years ago
Blocks: 1063365
(Assignee)

Comment 9

4 years ago
But I think doing that should be a separate bug, because I don't know how much work is involved and I'd rather not block landing this test code de-deduplication.  I filed bug 1063365 for that.

Comment 10

4 years ago
Comment on attachment 8484780 [details] [diff] [review]
Refactor MSE tests, introduce mediasource.js shared functions.

Review of attachment 8484780 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good, thanks.
Attachment #8484780 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/e67894f69449
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.