Closed
Bug 1063413
Opened 10 years ago
Closed 10 years ago
Do not pass a non-POD object to a variadic function in NativeFileWatcherWin.cpp.
Categories
(Toolkit Graveyard :: OS.File, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
7.28 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
This is not allowed on GCC 64-bit (mingw) and clang cl.
Attachment #8484854 -
Flags: review?(dteller)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8484854 [details] [diff] [review] patch Review of attachment 8484854 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, thanks. These LOGS probably never worked in the first place, too. Nit: Check your hg diff header and your commit message, they don't seem to match our usual format.
Attachment #8484854 -
Flags: review?(dteller) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Thanks for review. > Nit: Check your hg diff header and your commit message, they don't seem to > match our usual format. It's exported from git in a way to make it a bit more like hg diff. I use hg for pushing anyway, so there should be no problem. https://hg.mozilla.org/integration/mozilla-inbound/rev/e5b1a648ba01
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e5b1a648ba01
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•11 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•