Closed Bug 1063472 Opened 10 years ago Closed 10 years ago

[Enhancement for Mac OS X dmg] Add "write" permission for the group in Firefox.app

Categories

(Firefox :: Installer, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 394984

People

(Reporter: fravadona, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0 Build ID: 20140716183446 Steps to reproduce: Install a previous version of Firefox on Mac OS X with an user that has administration rights. Log as a different user that has also administration rights, launch Firefox and start the update process Actual results: Firefox update fails Expected results: Firefox update successes NB: A way to fix this behavior is to do "sudo chmod -R g+w /Application/Firefox.app" right after the installation of Firefox, but this fix will not work anymore after a "right restoration process is launched on OS X. The only way to fix it definitively is to add "write" right for the "group" in the BOM archive of the installer.
We don't have a pkg installer, just a dmg archive... is this just a question of the pre-existing file permissions of the files in that archive (which I would assume OS X keeps when moving it to /Applications/ ) ?
Flags: needinfo?(fravadona)
Oops sorry ! Lately I've been packaging several softwares and I've ran onto the same problem with the BOM archives (I forgot that the Firefox distribution is a disk image). So, I just created a new DMG of Firefox adding group "write" permission to the whole Firefox.app and OS X kept these pre-existing file permissions when moving it to /Applications/
Flags: needinfo?(fravadona)
To answer directly to your question : Yes, it's just a matter of pre-existing permissions of the files in the DMG. Now here are the reasons why only changing the group permissions in the DMG will work as expected : - When doing a copy/paste from a DMG, the pre-existing rights of the files are unchanged (but the owner and group are modified to match the ones of the user who does the copy/paste). - OS X only permits to users that has administration rights to install something in /Applications. - If an user has administration rights then its primary group is "admin" - When doing a copy/paste from a DMG, the pre-existing rights of the files are unchanged but the owner and group are modified to match the ones of the user who made the copy.
This makes sense to me, although I don't know how highly it needs to be prioritized. It'll probably involve fixing up http://mxr.mozilla.org/mozilla-central/source/build/package/mac_osx/pkg-dmg to get this right (or have an option to get this right), and it'd currently interfere with the repack stuff we're doing because of Apple's signing changes in Mavericks/Yosemite. CC'ing folks who know about these efforts - perhaps it can be incorporated there.
Status: UNCONFIRMED → NEW
Component: General → Installer
Ever confirmed: true
Summary: [Enhancement for Mac OS X installer] Add "write" permission for the group in Firefox.app → [Enhancement for Mac OS X dmg] Add "write" permission for the group in Firefox.app
This will be fixed via elevated updates (see bug 394984). We don't like to change permissions, since people rely on those in various ways. The patches are basically ready for code and security review, but Apple's v2 signature changes take priority at the moment.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.