Wiki publish no longer works in end_to_end_reconfig.sh since bug 1032351 landed

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: pmoore, Assigned: pmoore)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Since wiki upgrade to MediaWiki 1.23, automatic publish to:
https://wiki.mozilla.org/ReleaseEngineering/Maintenance
fails during end_to_end_reconfig.sh.

For example, this call no longer works:
https://hg.mozilla.org/build/tools/file/3819e11d9dfa/buildfarm/maintenance/update_maintenance_wiki.sh#l94

This is the information about the wiki upgrade:
https://wiki.mozilla.org/MozillaWiki:News/2014-08/Upgrade_to_MediaWiki_1.23

And the rollout was tracked in bug 1032351.

The merge day wiki update automation may also fail now:
https://hg.mozilla.org/build/tools/file/3819e11d9dfa/buildfarm/maintenance/update_merge_day_wiki.sh

It should be tested too.
(Assignee)

Comment 1

3 years ago
A simple workaround is to exit 0 at top of update_maintenance_wiki.sh until this is fixed.
(Assignee)

Comment 2

3 years ago
(and update wiki manually, of course)
It's just a matter of changing the ampersand to a question mark:

curl -s "https://wiki.mozilla.org/${WIKI_TITLE}?action=raw" >> "${current_content}"

And the same for all other instances.
(Assignee)

Comment 4

3 years ago
Created attachment 8495159 [details] [diff] [review]
bug1063479_tools_v1.patch

Thanks Gordon for looking into it! That fixed this query indeed.

The next time I run a reconfig I should be able to see if everything else is still working, so I'll leave this bug open for now in case there are any other issues further downstream with other wiki api calls, but hopefully that was the only one.

Thanks,
Pete
Assignee: nobody → pmoore
Status: NEW → ASSIGNED
Attachment #8495159 - Flags: review?(mgervasini)
(In reply to Pete Moore [:pete][:pmoore] from comment #4)
> The next time I run a reconfig I should be able to see if everything else is
> still working, so I'll leave this bug open for now in case there are any
> other issues further downstream with other wiki api calls, but hopefully
> that was the only one.

Well, I can confirm that there are about 4 similar instances in the update_merge_day_wiki.sh you linked to in comment 0. I'd recommend auditing all wiki URLs in your scripts for this.
Attachment #8495159 - Flags: review?(mgervasini) → review+
(Assignee)

Comment 6

3 years ago
Comment on attachment 8495159 [details] [diff] [review]
bug1063479_tools_v1.patch

It worked!!! \o/

Thanks guys!!
Attachment #8495159 - Flags: checked-in+
(Assignee)

Comment 7

3 years ago
https://wiki.mozilla.org/ReleaseEngineering/Maintenance#Reconfigs_.2F_Deployments
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

3 years ago
Ah, that was a bit premature, forgot to update merge day wiki script too! :D
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

3 years ago
Created attachment 8495250 [details] [diff] [review]
bug1063479_tools_v2.patch

Now also with changes required for merge day automation script too...
Attachment #8495159 - Attachment is obsolete: true
Attachment #8495250 - Flags: review?(mgervasini)
Attachment #8495250 - Flags: review?(mgervasini) → review+
(Assignee)

Updated

3 years ago
Attachment #8495250 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Attachment #8495159 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.