De-duplicate any entries from the autocomplete popup that differ only by purpose parameter for the default search engine

ASSIGNED
Assigned to

Status

()

defect
P4
normal
Rank:
47
ASSIGNED
5 years ago
2 years ago

People

(Reporter: alexbardas, Assigned: alexbardas)

Tracking

(Depends on 1 bug, Blocks 1 bug)

35 Branch
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
Fix the duplication that Bug 1063530 introduces by keeping only one result, when multiple results from the autocomplete popup are almost the same, but have a different purpose. Those with the "keyword" purpose should be kept.
Assignee: nobody → abardas
Status: NEW → ASSIGNED
Iteration: --- → 35.1
Points: --- → 3
Flags: qe-verify?
Flags: firefox-backlog+
Hi Alex, can you mark this bug as qe-verify+ or qe-verify-.
Flags: needinfo?(abardas)
Assignee

Updated

5 years ago
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(abardas)
Assignee

Updated

5 years ago
Depends on: 1063530
Assignee

Comment 3

5 years ago
What should be taken into consideration is that this bug / patch is applied on top of the one from bug 1063530. 

I'm more interested if this approach of removing the duplicates is good.

Updated

5 years ago
QA Contact: petruta.rasa
Comment on attachment 8487501 [details] [diff] [review]
Remove search results purpose and add it back when adding matches for awesomebar autocomplete popup

Review of attachment 8487501 [details] [diff] [review]:
-----------------------------------------------------------------

We talked about this in person a little, so I'll wait for the updated patch.
Attachment #8487501 - Flags: feedback?(adw)
Iteration: 35.1 → 35.2
Comment on attachment 8489821 [details] [diff] [review]
Remove search results purpose and add it back when adding matches for awesomebar autocomplete popup

Review of attachment 8489821 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is OK given the most recent patches in bug 1063530, but Gavin doesn't like the approach in that bug and wants to think about a better fix.  So it's likely that we won't ultimately take this patch.

Alex, I missed the last part of the meeting yesterday, but since this bug is blocked on bug 1063530, I think we should remove it from the current iteration.  Did you guys decide not to do that in the meeting?
Attachment #8489821 - Flags: feedback?(adw) → feedback+
Assignee

Comment 7

5 years ago
(In reply to Drew Willcoxon :adw from comment #6)
> Comment on attachment 8489821 [details] [diff] [review]
> Remove search results purpose and add it back when adding matches for
> awesomebar autocomplete popup
> 
> Review of attachment 8489821 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think this is OK given the most recent patches in bug 1063530, but Gavin
> 
> Alex, I missed the last part of the meeting yesterday, but since this bug is
> blocked on bug 1063530, I think we should remove it from the current
> iteration.  Did you guys decide not to do that in the meeting?

It was decided that for policy reasons (not technical), this will be postponed a bit and should be removed from the current iteration.
Blocks: 1071461
Iteration: 35.2 → ---

Comment 8

4 years ago
hi again - is this bug still relevant.  the last comment is that policy reasons we were deprioritizing.
Rank: 47
Flags: needinfo?(mak77)
Priority: -- → P4
Whiteboard: [fxsearch]
I didn't participate to the meeting that discussed those policy reasons, maybe Drew did?
We don't yet know if we will implement parsing existing search urls back to engine+search_terms, the feature was disabled because we couldn't properly distinguish text from image searches. If it stays disabled this bug is less important.
Flags: needinfo?(mak77) → needinfo?(adw)
This bug depends on bug 1063542, whose last status that I know of was that Gavin didn't like the patch there and he wanted to think about what we should do, but that was a while ago.
Flags: needinfo?(adw)
(In reply to Drew Willcoxon :adw from comment #10)
> This bug depends on bug 1063542

bug 1063530
You need to log in before you can comment on or make changes to this bug.