1063542 - De-duplicate any entries from the autocomplete popup that differ only by purpose parameter for the default search engine

Status: RESOLVED DUPLICATE of bug 1687643

(Firefox :: Search, defect, P5)

Description

[Alex Bardas :alexbardas]

Fix the duplication that Bug 1063530 introduces by keeping only one result, when multiple results from the autocomplete popup are almost the same, but have a different purpose. Those with the "keyword" purpose should be kept.

Comment 1

[Marco Mucci [:MarcoM]]

Hi Alex, can you mark this bug as qe-verify+ or qe-verify-.

Comment 2

[Alex Bardas :alexbardas]

Attachment: Remove search results purpose and add it back when adding matches for awesomebar autocomplete popup

Comment 3

[Alex Bardas :alexbardas]

What should be taken into consideration is that this bug / patch is applied on top of the one from bug 1063530. 

I'm more interested if this approach of removing the duplicates is good.

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 8487501 [details] [diff] [review]
Remove search results purpose and add it back when adding matches for awesomebar autocomplete popup

Review of attachment 8487501 [details] [diff] [review]:
-----------------------------------------------------------------

We talked about this in person a little, so I'll wait for the updated patch.

Comment 5

[Alex Bardas :alexbardas]

Attachment: Remove search results purpose and add it back when adding matches for awesomebar autocomplete popup

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 8489821 [details] [diff] [review]
Remove search results purpose and add it back when adding matches for awesomebar autocomplete popup

Review of attachment 8489821 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is OK given the most recent patches in bug 1063530, but Gavin doesn't like the approach in that bug and wants to think about a better fix.  So it's likely that we won't ultimately take this patch.

Alex, I missed the last part of the meeting yesterday, but since this bug is blocked on bug 1063530, I think we should remove it from the current iteration.  Did you guys decide not to do that in the meeting?

Comment 7

[Alex Bardas :alexbardas]

(In reply to Drew Willcoxon :adw from comment #6)
> Comment on attachment 8489821 [details] [diff] [review]
> Remove search results purpose and add it back when adding matches for
> awesomebar autocomplete popup
> 
> Review of attachment 8489821 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think this is OK given the most recent patches in bug 1063530, but Gavin
> 
> Alex, I missed the last part of the meeting yesterday, but since this bug is
> blocked on bug 1063530, I think we should remove it from the current
> iteration.  Did you guys decide not to do that in the meeting?

It was decided that for policy reasons (not technical), this will be postponed a bit and should be removed from the current iteration.

Comment 8

[:shell escalante]

hi again - is this bug still relevant.  the last comment is that policy reasons we were deprioritizing.

Comment 9

[Marco Bonardo [:mak]]

I didn't participate to the meeting that discussed those policy reasons, maybe Drew did?
We don't yet know if we will implement parsing existing search urls back to engine+search_terms, the feature was disabled because we couldn't properly distinguish text from image searches. If it stays disabled this bug is less important.

Comment 10

[Drew Willcoxon :adw]

This bug depends on bug 1063542, whose last status that I know of was that Gavin didn't like the patch there and he wanted to think about what we should do, but that was a while ago.

Comment 11

[Drew Willcoxon :adw]

(In reply to Drew Willcoxon :adw from comment #10)
> This bug depends on bug 1063542

bug 1063530

Comment 12

[Mark Banner (:standard8)]

I've just filed bug 1687643 to replace this, with a clearer description.