1063601 - [Ambient Indicator] Notifications received when the notification tray is open should not add a indicator

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Pang [:epang] UX]

Hi Alberto,

When the notification tray is open and a new notification comes in the ambient indicator should not appear since the user is already in the tray.

Currently if a new notification comes in when the tray is open the user needs to close the tray and open it again to dismiss the indicator.

Let me know if you have any question, thanks!

Comment 1

[Alberto Pastor [:albertopq]]

There is a little bit of refactor (done in Bug 1061854) needed for easily fixing this bug.

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23922

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8487547 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23922

One small nit on github, ie. the linter tests need to be fixed. Other than that I think we are good to go.

Comment 4

[Eric Pang [:epang] UX]

Comment on attachment 8487547 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23922

good to go for me, thanks Alberto!

Comment 5

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/d3ba11598172c46e839e48b150113b3269dfbff6

Comment 6

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Receiving notifications while the tray is open now, is a poor experience. Given the simplicity of the fix I would consider including it in 2.1

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, we should ask for uplift rather than nomination here. We don't need to block the release for it, but since its a low risk/high impact fix, it is reasonable to ask to have it in.

Comment 8

[Alberto Pastor [:albertopq]]

That makes sense :)

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8487547 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23922

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1042713
[User impact] if declined: User will see the ambient indicator, even when the tray is open
[Testing completed]: manual tests and added unit tests
[Risk to taking this patch] (and alternatives if risky): low risk. Only checking if the tray is open when incrementing the unread notifications.
[String changes made]: -

Comment 10

[bhavana bajaj [:bajaj]]

Comment on attachment 8487547 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23922

thanks for the tests here. Given the risk/reward here approving this to land on 2.1

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/b11e74449c1d54628d339c3b98ccc9802d59e904

Comment 12

[sarsenyev]

Verified the issue is fixed, the behavior is changed, before a  notification is received, the notification tray closes first if previously was open , it prevents the user receive notifications on the open notification tray
in bug 1073480 indicator is removed.

Device: Flame 2.2 Master KK
BuildID: 20141030040201
Gaia: 0dfc1996eb583c8b507a82bf6b8319624bba23ea
Gecko: 80e18ff7c7b2
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1 KK
BuildID: 20141030001201
Gaia: 3e585d8be5e2dffc376f83313299c9b6d53c3db4
Gecko: b643d78a23c6
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0