1063695 - Convert log_parser/parsers.py constants to class attributes

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P4)

Description

[Ed Morley [:emorley]]

(In reply to Jonathan Eads ( :jeads ) from bug 1043741 comment #9)
> 
> (In reply to Ed Morley [:edmorley] from bug 1043741 comment #7)
> > * I'm not sure why we have constants both inside and outside the StepParser
> > class. I can get that for the regex compiles we perhaps want to save
> > duplicating for each instance, but perhaps we should move
> > ST_STARTED/ST_FINISHED/DATE_FORMAT/RESULT_DICT out too?
> 
> The only reason I could see for this is the need to import
> RE_HEADER_VALUE/RE_HEADER_START/PATTERN/RE_STEP_START/RE_STEP_FINISH
> explicitly in other modules independently of HeaderParser and StepParser.
> Maybe at one time in development that was the case. However, grepping for
> those constants, I find no explicit imports.
> 
> These constants should be converted to class attributes on the classes,
> HeaderParser and StepParser, that use them.

Comment 1

[Ed Morley [:emorley]]

Attachment: Clean up constants in parsers.py

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/99989d3f222818dbc1bdf3cef20d41b2ebbec5bd
Bug 1063695 - Convert constants in parsers.py to class attributes

https://github.com/mozilla/treeherder/commit/b8df082ae272cf9846a34fd8d84e08309e273ae3
Bug 1063695 - Remove unused RE_INFO constant