1063711 - Ignore the cache when listing Tarako review queue

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[krupa raj[:krupa]]

Right now, the results are limited to the oldest 20 reviews. We should support pagination and show all apps in the queue at all times.

Comment 1

[Mark Striemer [:mstriemer]]

After further investigation this appears to be a caching issue. It's trying to put everything on the page but the cache is serving the old query results. I'm adding a no_cache() call to the query and we'll get everything all the time like the China review queue.

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/pull/2517

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/ad73c658b0b9d1fcabce4c91118f73403e42cc5e

Comment 4

[Mark Striemer [:mstriemer]]

The fix is just for the caching bug. If we see a need for pagination I'll add it later.

Comment 5

[Andrew Williamson [:eviljeff]]

when you say it was a caching bug do you mean that it should display all apps in the Tarako queue?

Comment 6

[Mark Striemer [:mstriemer]]

It should display all _approved_ apps in the Tarako queue. But since approving an app does not affect its review object it won't invalidate the SQL query performed on the Tarako queue page. This is what would happen:

1. User submits a new app.
2. User requests a Tarako review (app is still not approved).
3. A reviewer checks the queue *results get cached without app from step 1*.
4. App from step 1 gets approved.
5. A reviewer checks the queue and does not see app from step 1 (shown the cached results from step 3).

Comment 7

[Victor Carciu]

Now I can see all approved apps in Tarako review(I verified and more than 20 apps are displayed now) . I will mark this bug as verified.