Last Comment Bug 106379 - NSS Fails to build under ARM Linux
: NSS Fails to build under ARM Linux
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Build (show other bugs)
: 4.0
: Other Linux
: P2 normal (vote)
: 3.3.2
Assigned To: Wan-Teh Chang
: Wan-Teh Chang
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2001-10-23 18:09 PDT by Mark Crichton
Modified: 2001-10-26 17:44 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch. (600 bytes, patch)
2001-10-23 18:28 PDT, Wan-Teh Chang
no flags Details | Diff | Splinter Review

Description Mark Crichton 2001-10-23 18:09:33 PDT
Mozilla's NSS Build setup fails to recognize an OS_TEST of "armv4l".  Since 
there is no explicit test for it in Linux.mk, it will default to x86.

And, trust me, it's quite entertaining to watch arm-linux-as munch on x86 
code...

Simple fix is to add the following lines in the coreconf/Linux.mk file:

ifeq ($(OS_TEST),armv4l)
        OS_REL_CFLAGS   = -DLINUX1_2 -D_XOPEN_SOURCE
        CPU_ARCH        = armv4l

However, since you can have different ARM types (forst 2 are version, last for 
endian IIRC), there should be a smarter test.  However, since I think only 
recent ARMs can really chew Mozilla, armv4l might be best (it represents most 
Strongarms...dunno about the new XScale.  My ARM knowledge isn't great).
Comment 1 Wan-Teh Chang 2001-10-23 18:28:19 PDT
Thanks for the bug report.  NSS has never been compiled
on Linux/arm.  I will attach a patch for you to try.
(This patch is copied from the old NSPR build system.)
Comment 2 Wan-Teh Chang 2001-10-23 18:28:41 PDT
Created attachment 54816 [details] [diff] [review]
Proposed patch.
Comment 3 Mark Crichton 2001-10-25 13:12:56 PDT
Builds here.

Can't do a running test.  There appears to be some other possible bugs floating 
around somewhere.
Comment 4 Wan-Teh Chang 2001-10-26 17:44:10 PDT
The patch has been checked in on the tip and
the NSS_3_3_BRANCH.  The NSS_CLIENT_TAG has
been moved.

Note You need to log in before you can comment on or make changes to this bug.