Closed Bug 1063805 Opened 10 years ago Closed 10 years ago

WebGL - Add more validation to video texImage2D

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: wlitwinczyk, Assigned: wlitwinczyk)

Details

Attachments

(1 file, 1 obsolete file)

tex2d_html_validation
3.02 KB, patch
wlitwinczyk
: review+
Details | Diff | Splinter Review 
The video/html element version of texSubImage2D is missing some validation.

http://dxr.mozilla.org/mozilla-central/source/dom/canvas/WebGLContext.h#537
Attached patch tex2d_html_validation (obsolete) — — Splinter Review 

        Attachment #8485240 -
        Flags: review?(jgilbert)

        Attachment #8485240 -
        Flags: review?(jgilbert) → review+

    
    

    
  


  
r=jgilbert carried forward. Minor rename issue.

I used the wrong variable (copy + paste issue) for some of the statements:
Old Try: https://tbpl.mozilla.org/?tree=Try&rev=cc967e44ab46

New Try: https://tbpl.mozilla.org/?tree=Try&rev=381cbbce0653

        Attachment #8485240 -
        Attachment is obsolete: true

        Attachment #8485958 -
        Flags: review+

    
    

    
  
Try passes
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/24e1c39a634b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: