1063860 - Refresh some of the variable/tier associations in mozbuild.context

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Looking at the content of VARIABLES for variables associated with 'libs', it seems there are leftovers from before bug 1043344, and some possibly wrong/unnecessary associations as well.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Refresh some of the variable/tier associations in mozbuild.context

https://tbpl.mozilla.org/?tree=Try&rev=7ff37f6240f4

Comment 2

[Mike Hommey [:glandium]]

This makes us skip about 150 more directories during the libs tier.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8485318 [details] [diff] [review]
Refresh some of the variable/tier associations in mozbuild.context

Review of attachment 8485318 [details] [diff] [review]:
-----------------------------------------------------------------

r+ conditional on not changing XPIDL_SOURCES, which I'm pretty sure will break the build (or tests since missing xpt likely won't get detected by the build alone).

::: python/mozbuild/mozbuild/frontend/context.py
@@ +700,5 @@
>  
>          This is a list of files that define XPCOM interface definitions.
>          Entries must be files that exist. Entries are almost certainly ``.idl``
>          files.
> +        """, 'export'),

We still do interfaces.manifest registration during libs. That's derived from xpt, which is derived from XPIDL_SOURCES/XPIDL_MODULE.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] (away Sep 10 through 27) from comment #3)
> We still do interfaces.manifest registration during libs. That's derived
> from xpt, which is derived from XPIDL_SOURCES/XPIDL_MODULE.

Yeah, try turned red. I guess that could move to export, though, but that should be a separate bug.

Comment 5

[Mike Hommey [:glandium]]

... although... it's XPIDL_SOURCES that made the difference on the number of directories :(

Comment 6

[Mike Hommey [:glandium]]

Filed bug 1063874 for XPIDL_SOURCES

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed9082b0bdd

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ed9082b0bdd