1063874 - Move the parts of XPIDL_SOURCES handling still in libs to export.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

That'd move about 130 directories from libs to export.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move the parts of XPIDL_SOURCES handling still in libs to export

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8485338 [details] [diff] [review]
Move the parts of XPIDL_SOURCES handling still in libs to export

Review of attachment 8485338 [details] [diff] [review]:
-----------------------------------------------------------------

Please run this through Try first. I /think/ the $(MAKE) -C ... XPI_NAME=foo rules explicitly evaluate the libs target and expect this rule to run. I believe this because I believe I tried this simple optimization before and ran into this problem.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] (away Sep 10 through 27) from comment #2)
> Comment on attachment 8485338 [details] [diff] [review]
> Move the parts of XPIDL_SOURCES handling still in libs to export
> 
> Review of attachment 8485338 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please run this through Try first. I /think/ the $(MAKE) -C ... XPI_NAME=foo
> rules explicitly evaluate the libs target and expect this rule to run. I
> believe this because I believe I tried this simple optimization before and
> ran into this problem.

Indeed, the one that matters is called with $(MAKE) -C $(DEPTH)/netwerk/test/httpserver libs XPI_NAME=reftest, but it actually very likely doesn't matter: I don't think anything actually needs the xpt file in the reftest addon. So my question here would be: do we care about theoretical correctness, or reftests being green?

Comment 4

[Gregory Szorc [:gps]]

We care about reftests being green and developers not complaining.

Comment 5

[Mike Hommey [:glandium]]

Refreshed and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75bab86b7ea9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75bab86b7ea9