Closed Bug 1063874 Opened 5 years ago Closed 5 years ago

Move the parts of XPIDL_SOURCES handling still in libs to export.

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

That'd move about 130 directories from libs to export.
Comment on attachment 8485338 [details] [diff] [review]
Move the parts of XPIDL_SOURCES handling still in libs to export

Review of attachment 8485338 [details] [diff] [review]:
-----------------------------------------------------------------

Please run this through Try first. I /think/ the $(MAKE) -C ... XPI_NAME=foo rules explicitly evaluate the libs target and expect this rule to run. I believe this because I believe I tried this simple optimization before and ran into this problem.
Attachment #8485338 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] (away Sep 10 through 27) from comment #2)
> Comment on attachment 8485338 [details] [diff] [review]
> Move the parts of XPIDL_SOURCES handling still in libs to export
> 
> Review of attachment 8485338 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please run this through Try first. I /think/ the $(MAKE) -C ... XPI_NAME=foo
> rules explicitly evaluate the libs target and expect this rule to run. I
> believe this because I believe I tried this simple optimization before and
> ran into this problem.

Indeed, the one that matters is called with $(MAKE) -C $(DEPTH)/netwerk/test/httpserver libs XPI_NAME=reftest, but it actually very likely doesn't matter: I don't think anything actually needs the xpt file in the reftest addon. So my question here would be: do we care about theoretical correctness, or reftests being green?
Flags: needinfo?(gps)
We care about reftests being green and developers not complaining.
Flags: needinfo?(gps)
https://hg.mozilla.org/mozilla-central/rev/75bab86b7ea9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.