Stop uploading gecko-unsigned-unaligned.apk to automation

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
All
Android

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
There's really no reason to upload gecko-unsigned-unaligned.apk any more.  Anything you can do with that APK, you can do with the *actual* Fennec APK.  Let's save ~30-40M per build.

Turning this off in mozilla-central is trivial.

I see it being used in some "android snippets" thing in the buildbots [1], but perhaps only for extracting the buildid.  This can either be done by using the actual Fennec APK; or by querying the build JSON directly, which will reduce network traffic.

[1] http://mxr.mozilla.org/build/source/tools/scripts/android/android_snippet.py#180
+lots to this.

The android snippet generation is related to the old update server (aus3.m.o), which we can go ahead and disable now IMO. bhearsum, ok with you for nightly builds ? 

Then we don't need to upload gecko-unsigned-unaligned.apk, which is probably just a Build Config change at http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#339
Component: Release Automation → General Automation
Flags: needinfo?(bhearsum)
QA Contact: bhearsum → catlee
(In reply to Nick Thomas [:nthomas] from comment #1)
> +lots to this.
> 
> The android snippet generation is related to the old update server
> (aus3.m.o), which we can go ahead and disable now IMO. bhearsum, ok with you
> for nightly builds ? 

Yeah, that's fine with me -- users have had almost a year to get a build with aus4.m.o in it.
Flags: needinfo?(bhearsum)
Bug 933426 handles turning off snippet generation.
Depends on: 933426
(Assignee)

Comment 4

3 years ago
Oh, of course I filed about this already.  I want this because it's inconvenient for Bug 1093218 to continue uploading gecko-unsigned-unaligned.apk.  How do I get releng to stop using this APK?
Flags: needinfo?(nthomas)
If we wait just a little longer, bug 1055918 will mean that all the desktop builds will be off the code path we need to change here, leaving just Android and making it much easier to make changes. Lets do that work in bug 933426 still.
Flags: needinfo?(nthomas)
(Assignee)

Comment 6

3 years ago
Now that Bug 933426 has landed, it looks like the unsigned unaligned APK is no longer used [1] [2].  It's still fished, but not used.  Is it okay for the fishing fail, since the result is not used?  If so, we can stop uploading \o/

[1] http://mxr.mozilla.org/build/search?string=unsigned-unaligned&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=build

[2] http://mxr.mozilla.org/build/search?string=unsignedApkUrl&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=build
Flags: needinfo?(nthomas)
Yes, go ahead with dropping the upload.
Flags: needinfo?(nthomas)
https://dxr.mozilla.org/mozilla-central/source/build/gen_mach_buildprops.py#51 and 52 can also be removed while you're modifying in-tree code.
(In reply to Nick Thomas [:nthomas] from comment #8)
> https://dxr.mozilla.org/mozilla-central/source/build/gen_mach_buildprops.
> py#51 and 52 can also be removed while you're modifying in-tree code.

Nick, do we need to remove this to close the bug?
Flags: needinfo?(nalexander)
(Assignee)

Comment 10

3 years ago
(In reply to Rail Aliiev [:rail] from comment #9)
> (In reply to Nick Thomas [:nthomas] from comment #8)
> > https://dxr.mozilla.org/mozilla-central/source/build/gen_mach_buildprops.
> > py#51 and 52 can also be removed while you're modifying in-tree code.
> 
> Nick, do we need to remove this to close the bug?

I think so.  I can't be bothered to chase all the places automation uses this cruft, see: http://mxr.mozilla.org/build/search?string=unaligned&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=build

If those are benign or not used or can be removed, kill the gen_mach_buildprops and let's finally get rid of this.  \o/
Flags: needinfo?(nalexander)
(Assignee)

Comment 12

2 years ago
Created attachment 8734520 [details]
MozReview Request: Bug 1063966 - Stop building and uploading gecko-unsigned-unaligned.apk. r?nthomas

This is still referenced out of tree, but only to optionally (!) find
it or to ignore it:

http://mxr.mozilla.org/build/search?string=unsigned-unaligned&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build

Review commit: https://reviewboard.mozilla.org/r/42327/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42327/
Attachment #8734520 - Flags: review?(nthomas)
Comment on attachment 8734520 [details]
MozReview Request: Bug 1063966 - Stop building and uploading gecko-unsigned-unaligned.apk. r?nthomas

https://reviewboard.mozilla.org/r/42327/#review39699

Looks fine to me. You could also fix up testing/mozharness/mozharness/mozilla/building/buildbase.py and build/upload.py if you're feeling energetic. You'll need an additional reviewer for toolkit/mozapps/installer/upload-files-APK.mk
Attachment #8734520 - Flags: review?(nthomas) → review+
(Assignee)

Comment 14

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/e1c798332d3be8aed7b934d2e6b3982d5de7d902
Bug 1063966 - Stop building and uploading gecko-unsigned-unaligned.apk. r=nthomas
(Assignee)

Comment 15

2 years ago
(In reply to Nick Thomas [:nthomas] from comment #13)
> Comment on attachment 8734520 [details]
> MozReview Request: Bug 1063966 - Stop building and uploading
> gecko-unsigned-unaligned.apk. r?nthomas
> 
> https://reviewboard.mozilla.org/r/42327/#review39699
> 
> Looks fine to me. You could also fix up
> testing/mozharness/mozharness/mozilla/building/buildbase.py and
> build/upload.py if you're feeling energetic.

I did this.  Not sure why I didn't do it up front, tbh -- not always easy to tell what's used from where.

 You'll need an additional
> reviewer for toolkit/mozapps/installer/upload-files-APK.mk

I'll self review -- I'm a peer in this area and it's trivial.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED

Comment 16

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e1c798332d3b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.