Closed Bug 1063966 Opened 10 years ago Closed 8 years ago

Stop uploading gecko-unsigned-unaligned.apk to automation

Categories

(Release Engineering :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Tracking Status
firefox48 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

There's really no reason to upload gecko-unsigned-unaligned.apk any more.  Anything you can do with that APK, you can do with the *actual* Fennec APK.  Let's save ~30-40M per build.

Turning this off in mozilla-central is trivial.

I see it being used in some "android snippets" thing in the buildbots [1], but perhaps only for extracting the buildid.  This can either be done by using the actual Fennec APK; or by querying the build JSON directly, which will reduce network traffic.

[1] http://mxr.mozilla.org/build/source/tools/scripts/android/android_snippet.py#180
+lots to this.

The android snippet generation is related to the old update server (aus3.m.o), which we can go ahead and disable now IMO. bhearsum, ok with you for nightly builds ? 

Then we don't need to upload gecko-unsigned-unaligned.apk, which is probably just a Build Config change at http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#339
Component: Release Automation → General Automation
Flags: needinfo?(bhearsum)
QA Contact: bhearsum → catlee
(In reply to Nick Thomas [:nthomas] from comment #1)
> +lots to this.
> 
> The android snippet generation is related to the old update server
> (aus3.m.o), which we can go ahead and disable now IMO. bhearsum, ok with you
> for nightly builds ? 

Yeah, that's fine with me -- users have had almost a year to get a build with aus4.m.o in it.
Flags: needinfo?(bhearsum)
Bug 933426 handles turning off snippet generation.
Depends on: 933426
Oh, of course I filed about this already.  I want this because it's inconvenient for Bug 1093218 to continue uploading gecko-unsigned-unaligned.apk.  How do I get releng to stop using this APK?
Flags: needinfo?(nthomas)
If we wait just a little longer, bug 1055918 will mean that all the desktop builds will be off the code path we need to change here, leaving just Android and making it much easier to make changes. Lets do that work in bug 933426 still.
Flags: needinfo?(nthomas)
Now that Bug 933426 has landed, it looks like the unsigned unaligned APK is no longer used [1] [2].  It's still fished, but not used.  Is it okay for the fishing fail, since the result is not used?  If so, we can stop uploading \o/

[1] http://mxr.mozilla.org/build/search?string=unsigned-unaligned&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=build

[2] http://mxr.mozilla.org/build/search?string=unsignedApkUrl&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=build
Flags: needinfo?(nthomas)
Yes, go ahead with dropping the upload.
Flags: needinfo?(nthomas)
https://dxr.mozilla.org/mozilla-central/source/build/gen_mach_buildprops.py#51 and 52 can also be removed while you're modifying in-tree code.
(In reply to Nick Thomas [:nthomas] from comment #8)
> https://dxr.mozilla.org/mozilla-central/source/build/gen_mach_buildprops.
> py#51 and 52 can also be removed while you're modifying in-tree code.

Nick, do we need to remove this to close the bug?
Flags: needinfo?(nalexander)
(In reply to Rail Aliiev [:rail] from comment #9)
> (In reply to Nick Thomas [:nthomas] from comment #8)
> > https://dxr.mozilla.org/mozilla-central/source/build/gen_mach_buildprops.
> > py#51 and 52 can also be removed while you're modifying in-tree code.
> 
> Nick, do we need to remove this to close the bug?

I think so.  I can't be bothered to chase all the places automation uses this cruft, see: http://mxr.mozilla.org/build/search?string=unaligned&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=build

If those are benign or not used or can be removed, kill the gen_mach_buildprops and let's finally get rid of this.  \o/
Flags: needinfo?(nalexander)
Comment on attachment 8734520 [details]
MozReview Request: Bug 1063966 - Stop building and uploading gecko-unsigned-unaligned.apk. r?nthomas

https://reviewboard.mozilla.org/r/42327/#review39699

Looks fine to me. You could also fix up testing/mozharness/mozharness/mozilla/building/buildbase.py and build/upload.py if you're feeling energetic. You'll need an additional reviewer for toolkit/mozapps/installer/upload-files-APK.mk
Attachment #8734520 - Flags: review?(nthomas) → review+
https://hg.mozilla.org/integration/fx-team/rev/e1c798332d3be8aed7b934d2e6b3982d5de7d902
Bug 1063966 - Stop building and uploading gecko-unsigned-unaligned.apk. r=nthomas
(In reply to Nick Thomas [:nthomas] from comment #13)
> Comment on attachment 8734520 [details]
> MozReview Request: Bug 1063966 - Stop building and uploading
> gecko-unsigned-unaligned.apk. r?nthomas
> 
> https://reviewboard.mozilla.org/r/42327/#review39699
> 
> Looks fine to me. You could also fix up
> testing/mozharness/mozharness/mozilla/building/buildbase.py and
> build/upload.py if you're feeling energetic.

I did this.  Not sure why I didn't do it up front, tbh -- not always easy to tell what's used from where.

 You'll need an additional
> reviewer for toolkit/mozapps/installer/upload-files-APK.mk

I'll self review -- I'm a peer in this area and it's trivial.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/e1c798332d3b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.