1063978 - Browser loses focus when Flash Plug-in is loaded for the first time

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: regression 

This problem happens when Flash Plug-in is loaded for the first time.
This Problem reproduce on clean profile, no-addon

Steps To Reproduce:

STR:
1. Enable Title Bar
2. Restart Browser
3. Open http://webhtb.sourceforge.net/video_demo.html
   ----  Flash Plug-in is loaded for the first time

Actual Results:
Title Bar becomes inactive state (On Windows Basic and Classic visual style)
Window control buttons become inactive state (On Windows Aero visual style)

Expected Results:
Browser should be staying in active state.

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8430feba6148
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140829114701
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3f0f2be0ab6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140829115701
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8430feba6148&tochange=b3f0f2be0ab6

Regressed by:
b3f0f2be0ab6	Aaron Klotz — Bug 768802: Prevent plugins from setting the foreground window during NP_Initialize; r=bsmedberg

Comment 1

[Alice0775 White]

It seems that the problem does not happen if windowless(i.e., wmode="opaque" or "transparent").

Comment 4

[Georg Fritzsche [:gfritzsche]]

Yes, it's not a major security incident or everyone crashing.
Please stick to constructive input on the bug at hand.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

I'm looking into it. One of the child windows is activating after creation.

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

This seems to be fixed either with the latest hourly build based on cset: 
https://hg.mozilla.org/mozilla-central/rev/4d1793da0b96

or...

Today's Update to Flash to version:  15.0.0.152  fixed the issue.  

With this test-case I am now no longer able to reproduce the loss of 'focus.'

Comment 7

[Masatoshi Kimura [:emk]]

According to bug 1061257, Flash Player 15 has a fix for bug 768802. We should backout the LockSetForgroundWindow "fix" because it has a regression (this bug).

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Masatoshi Kimura [:emk] from comment #7)
> According to bug 1061257, Flash Player 15 has a fix for bug 768802. We
> should backout the LockSetForgroundWindow "fix" because it has a regression
> (this bug).

I think that we should be verifying Flash Player 15's behavior both with and without bug 768802 before deciding to do anything.

Comment 9

[Alice0775 White]

Flash Player 15.0.0.152 fixed the problem.
I cannot reproduce the problem.

Comment 10

[Masatoshi Kimura [:emk]]

According to a mail sent to me, Flash Player 15 definitely fixed bug 768802 even without the patch.