Closed Bug 1064172 Opened 11 years ago Closed 7 years ago

ligatures/shaping should break for inline margin/border/padding and vertical-align

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: dbaron, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

testcase
645 bytes, text/html; charset=UTF-8
Details
Prevent shaping across element boundaries when margin/border/padding is present, vertical-align is not 'baseline', or there is a bidi isolation boundary
4.71 KB, patch
jwatt
: review+
Details | Diff | Splinter Review
Add WPT reftests for properties that inhibit text shaping across inline element boundaries
17.93 KB, patch
jwatt
: review+
Details | Diff | Splinter Review
Attached file testcase —
The CSSWG agreed to accept https://lists.w3.org/Archives/Public/www-style/2014Aug/0217.html which says that ligatures/shaping should break for: * inline margin/border/padding that falls in the middle of the text * when crossing an element boundary where vertical-align is not baseline (even if both match) http://www.w3.org/2014/09/08-css-irc#T08-02-24 (Though it's worth making sure the eventual spec edits match what we discussed today.)
(In reply to David Baron [:dbaron] (UTC+2) (needinfo? for questions) (away/busy until Sep 11) from comment #0) > The CSSWG agreed to accept > https://lists.w3.org/Archives/Public/www-style/2014Aug/0217.html which says > that ligatures/shaping should break for: > * inline margin/border/padding that falls in the middle of the text > * when crossing an element boundary where vertical-align is not baseline > (even if both match) > > http://www.w3.org/2014/09/08-css-irc#T08-02-24 > > (Though it's worth making sure the eventual spec edits match what we > discussed today.) The first requirement makes sense but I think the 'vertical-align' case is misguided. http://lists.w3.org/Archives/Public/www-style/2014Sep/0120.html
This blocks ligature formation (cross-inline-boundary shaping) in all dbaron's examples from the testcase.
Attachment #9029605 - Flags: review?(jwatt)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
A bunch of individual examples in WPT reftest form.
Attachment #9029606 - Flags: review?(jwatt)
Comment on attachment 9029605 [details] [diff] [review] Prevent shaping across element boundaries when margin/border/padding is present, vertical-align is not 'baseline', or there is a bidi isolation boundary Review of attachment 9029605 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsTextFrame.cpp @@ +1900,5 @@ > + > + // Map inline-end and inline-start to physical sides for checking presence > + // of non-zero margin/border/padding. > + mozilla::Side side1 = wm.PhysicalSide(eLogicalSideIEnd); > + mozilla::Side side2 = wm.PhysicalSide(eLogicalSideIStart); I feel like we shouldn't need the namespace prefix. @@ +1904,5 @@ > + mozilla::Side side2 = wm.PhysicalSide(eLogicalSideIStart); > + // If the frames have an embedding level that is opposite to the writing > + // mode, we need to swap which sides we're checking. > + if (IS_LEVEL_RTL(aFrame1->GetEmbeddingLevel()) == wm.IsBidiLTR()) { > + mozilla::Swap(side1, side2); Ditto.
Attachment #9029605 - Flags: review?(jwatt) → review+
Right; not sure why the prefixes ended up there, it builds fine without them. Removed.
Attachment #9029606 - Flags: review?(jwatt) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/107a4383fa0c Prevent shaping across element boundaries when margin/border/padding is present, vertical-align is not 'baseline', or there is a bidi isolation boundary. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/8126c43fb9e7 Add WPT reftests for properties that inhibit text shaping across inline element boundaries. r=jwatt
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14688 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Backed out 2 changesets (bug 1064172) for Wr failures at /css/css-text/boundary-shaping/boundary-shaping-010.html Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/51b648c8884895aa47c40cb241cf60eea1730ff1 Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=219220823&revision=8126c43fb9e7a654fef53401c9caf745c67f2b91 Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219223098&repo=mozilla-inbound&lineNumber=26814 06:36:15 INFO - TEST-START | /css/css-text/boundary-shaping/boundary-shaping-010.html 06:36:15 INFO - PID 2082 | 1546094175643 Marionette INFO Testing http://web-platform.test:8000/css/css-text/boundary-shaping/boundary-shaping-010.html == http://web-platform.test:8000/css/css-text/boundary-shaping/reference/boundary-shaping-010.ref.html 06:36:15 INFO - PID 2082 | ++DOMWINDOW == 22 (0x121b0dc00) [pid = 2087] [serial = 22] [outer = 0x11eb06400] 06:36:15 INFO - PID 2082 | ++DOMWINDOW == 23 (0x121b0f400) [pid = 2087] [serial = 23] [outer = 0x11eb06400] 06:36:15 INFO - PID 2082 | 1546094175754 Marionette INFO No differences allowed 06:36:15 INFO - PID 2082 | 1546094175754 Marionette INFO Found 4 pixels different, maximum difference per channel 1 06:36:15 INFO - TEST-UNEXPECTED-FAIL | /css/css-text/boundary-shaping/boundary-shaping-010.html | Testing http://web-platform.test:8000/css/css-text/boundary-shaping/boundary-shaping-010.html == http://web-platform.test:8000/css/css-text/boundary-shaping/reference/boundary-shaping-010.ref.html 06:36:15 INFO - REFTEST IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAlgAAAJYCAYAAAC+ZpjcAAAQGklEQVR4nO3drW5r23qA4XkPW6oOORfQqlJQpSOVlGy5oJKvoLKKCwxzCYGBgYGGgYGGgYaGgYaBhqMgf05WfrfeldWd/TySpaUktudir8Yc8xvTAAAgNf3qCwAA+G4EFgBATGABAMQEFgBATGABAMQEFgBATGABAMQEFgBATGABAMQEFgBATGABAMQEFvCXt91sxv5XXwTwrQgs4K9tvxlH0zRW2zcSay+/gM8RWMBPs99dj+129+nVod3lyTjbfE3U7LfnY5qmMU3TOD67GNub5997M06m2fiiywG+CYEF/DSXy+khXubH52Oz+0il3IyzaRqz1fanX98YY2xX84drnKZpTEfnT4Jwvzkb0zSNi+svuRzgmxBYwE+yHxeL6Wm8TNNYnK3HzVvv2q7GNE3j6GT9JVe5PX8WWPPVQWDdjPPZ7c/P37qFCPCMwAJ+mpcC6/Y1H+vrl4Nld3l8+zez1ZdsPL/ZrMbs8NoOv3e/HfP7MFxdf8HVAN+FwAJ+mvvVqNdep+vdj2+6vrj7/XJ8zU3Cp7cJn9yaPAis+RfdsgS+B4EF/FSbs/mbkXV8ef3sHfdRM/+yjeU3V6cPtwef2o3To7trXVx8zcUA34LAAn66zWr5iZWs/VjNv3bf0+NK2+LZqtnjtTzdmwXwNoEFfIn9bjtW56fj/PI2YTar44PIOhqPjXUQWF+1hLXfvLpqtj6Z3V3j8bj+mqsBvgGBBfwyu8uTF5/eu3+yb37+ZbuwxmJ6edVsu1o8bMz3ICHwUQIL+KUO92idbW4HONxHzdcF1uOq2cmzjfcPTzVOs3H11nwJgAMCC/jFHuNmdrYZY4xfsu/p4m4o6g9Rd/Ak5JfdsgT+9AQW8OvdrMfR3QyqMX5NYD3cCnz2nYejJt48rxDggMAC/l/Yns/GNL8Y+/3mYPDnIt73tB+r2ctPJ+7Wd/vBZudPJ80/bICfxsIsLOCDBBbwh+x327G5uhqbzfbNo28+/oHbcXp2MS7PFo8b36fFO7Ow9mO1PH7zb7ar44eVp8N5V8/f8rhS9Wwz++Gw0S/bEwb82Qks4NOufhgeejTOr16Yyv5Zu/XdgcuLsZgdvXtbbr89v52jtXkt8bZjdjCF/frhicAXNqzf3K+cHY6MGGOM67EUWMAnCSzgU64vXh8a+vwJvE+52TyMSlheXI3V3abz47c+8/723atT1m9vCT6uWN2M81eHmD6uVD393eMmfIEFfJTAAj5u/zgvaprNx3z2Y2RdXP+Bz92tH+Lm9hbdflzcb3Q/Xr/xxsfreW2l6zaOjsb65v6/sHolsB5D6uleK4EFfJ7AAj5utx6zaRqL1ebgR+e3TwA+vE7GZ9axtuvTJ4F2dHr72ZfL+5/NHuLox8s5e7Jf64e7lIfhtlzd7hW7uRpHrxzDc7l4Oi7i1t0qmMACPkFgAX/Afuyut2O9vhyr1ekPq1hnH5gXdXO9GSfz5ytgj0fV7NaHR+n8ffzt7/8Y/7NcjuVyOZbLxZgdPX/vXRwtFmO5XI7FfPbC74/Gv979+/f//t+7z3r8zIe/m50/2QS/Ob39rJnAAj5IYAEftt9djZPFS+Hy9PX6Ic37sb26GMc/hNULe7juZ2P9itezpwzvZ2SdvLaUBvCMwAI+ZHd19uFAeR5Yu+1mrE5f3xw/TdM4fWEz++bs/Zj7Ka8XV7CWDnsGPkxgAe97Mvzzx9fRbDbm8/mYz+djNpuPi+v92F9fjbOT5burULPF2di8umlrP67Oj8d//Nu/jN/+6Z/H73ffMZ/Px3yxGCenq7HZ7cfY78Z6dTqWi4Pfzxfj+ORsrDe7McZ+bC5X43i5GP/570fjt9/+Nv7x+38d/O3hazYWZ1dPruFsmsb8D+3eB/6qBBbwrqejGY7GyepybLa7cfPGVqvd+nzMF8uxPD4ex8cn4/T0bJyfr8bF5XpcbTbjencz9n+Sk2dudrsvO7IH+B4EFvCu7epusOj8vJnaDvDNCSzgXfebvOfO4gP4EIEFvOv+FuHT+VAAvEZgAe+7vj8I+XNDRAH+qgQW8AGPBx5fKCyAdwks4EPWx0djmp6f0wfASwQW8CE3V3dH4sxWRhYAvENgAR/zMGx0MV49CQeAMYbAAj5sP1bzpwcyA/AygQV82O5iOaZpJrAA3iGwgI+7uRzTdGxUA8A7BBbwCTfjau0pQoD3CCwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgNj/AfLbOjq7lprcAAAAAElFTkSuQmCC 06:36:15 INFO - REFTEST IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAlgAAAJYCAYAAAC+ZpjcAAAQGElEQVR4nO3drW5r23qA4XkPW6oOOTdwVDWoUquSki2jyndQq7ySYS4hMDAw0DAw0DDQ0DDQMNBwFOTPycrv1ruyurOfR7K0lMT2XOzVmGN+YxoAAKSmX30BAADfjcACAIgJLACAmMACAIgJLACAmMACAIgJLACAmMACAIgJLACAmMACAIgJLACAmMAC/vK2m83Y/+qLAL4VgQX8te0342iaxmr7RmLt5RfwOQIL+Gn2u+ux3e4+vTq0uzwZZ5uviZr99nxM0zSmaRrHZxdje/P8e2/GyTQbX3Q5wDchsICf5nI5PcTL/Ph8bHYfqZSbcTZNY7ba/vTrG2OM7Wr+cI3TNI3p6PxJEO43Z2OapnFx/SWXA3wTAgv4SfbjYjE9jZdpGouz9bh5613b1ZimaRydrL/kKrfnzwJrvjoIrJtxPrv9+flbtxABnhFYwE/zUmDdvuZjff1ysOwuj2//Zrb6ko3nN5vVmB1e2+H37rdjfh+Gq+svuBrguxBYwE9zvxr12ut0vfvxTdcXd79fjq+5Sfj0NuGTW5MHgTX/oluWwPcgsICfanM2fzOyji+vn73jPmrmX7ax/Obq9OH24FO7cXp0d62Li6+5GOBbEFjAT7dZLT+xkrUfq/nX7nt6XGlbPFs1e7yWp3uzAN4msIAvsd9tx+r8dJxf3ibMZnV8EFlH47GxDgLrq5aw9ptXV83WJ7O7azwe119zNcA3ILCAX2Z3efLi03v3T/bNz79sF9ZYTC+vmm1Xi4eN+R4kBD5KYAG/1OEerbPN7QCH+6j5usB6XDU7ebbx/uGpxmk2rt6aLwFwQGABv9hj3MzONmOM8Uv2PV3cDUX9IeoOnoT8sluWwJ+ewAJ+vZv1OLqbQTXGrwmsh1uBz77zcNTEm+cVAhwQWMD/C9vz2ZjmF2O/3xwM/lzE+572YzV7+enE3fpuP9js/Omk+YcN8NNYmIUFfJDAAv6Q/W47NldXY7PZvnn0zcc/cDtOzy7G5dniceP7tHhnFtZ+rJbHb/7NdnX8sPJ0OO/q+VseV6qebWY/HDb6ZXvCgD87gQV82tUPw0OPxvnVC1PZP2u3vjtweTEWs6N3b8vtt+e3c7Q2ryXedswOprBfPzwR+MKG9Zv7lbPDkRFjjHE9lgIL+CSBBXzK9cXrQ0OfP4H3KTebh1EJy4ursbrbdH781mfe3757dcr67S3BxxWrm3H+6hDTx5Wqp7973IQvsICPEljAx+0f50VNs/mYz36MrIvrP/C5u/VD3NzeotuPi/uN7sfrN974eD2vrXTdxtHRWN/c/xdWrwTWY0g93WslsIDPE1jAx+3WYzZNY7HaHPzo/PYJwIfXyfjMOtZ2ffok0I5Obz/7cnn/s9lDHP14OWdP9mv9cJfyMNyWq9u9YjdX4+iVY3guF0/HRdy6WwUTWMAnCCzgD9iP3fV2rNeXY7U6/WEV6+wD86JurjfjZP58BezxqJrd+vAonb+Pv/3938b/LJdjuVyO5XIxZkfP33sXR4vFWC6XYzGfvfD7o/HPd//+/b//9+6zHj/z4e9m5082wW9Obz9rJrCADxJYwIftd1fjZPFSuDx9vX5I835sry7G8Q9h9cIervvZWL/i9ewpw/sZWSevLaUBPCOwgA/ZXZ19OFCeB9Zuuxmr09c3x0/TNE5f2My+OXs/5n7K68UVrKXDnoEPE1jA+54M//zxdTSbjfl8Pubz+ZjN5uPiej/211fj7GT57irUbHE2Nq9u2tqPq/Pj8Z//+o/x2z/9Y/x+9x3z+XzMF4txcroam91+jP1urFenY7k4+P18MY5PzsZ6sxtj7MfmcjWOl4sx+49/Gb/99rfx77//18HfHr5mY3F29eQazqZpzP/Q7n3gr0pgAe96OprhaJysLsdmuxs3b2y12q3Px3yxHMvj43F8fDJOT8/G+flqXFyux9VmM653N2P/Jzl55ma3+7Ije4DvQWAB79qu7gaLzs+bqe0A35zAAt51v8l77iw+gA8RWMC77m8RPp0PBcBrBBbwvuv7g5A/N0QU4K9KYAEf8Hjg8YXCAniXwAI+ZH18NKbp+Tl9ALxEYAEfcnN1dyTObGVkAcA7BBbwMQ/DRhfj1ZNwABhjCCzgw/ZjNX96IDMALxNYwIftLpZjmmYCC+AdAgv4uJvLMU3HRjUAvENgAZ9wM67WniIEeI/AAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCICSwAgJjAAgCI/R85VTo9Ln6hGgAAAABJRU5ErkJggg== 06:36:15 INFO - TEST-INFO took 157ms
Flags: needinfo?(jfkthame)
This is failing on css/css-text/boundary-shaping/boundary-shaping-004.html too: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219223707&repo=mozilla-inbound&lineNumber=8899
Upstream PR was closed without merging
The tests aren't failing in a meaningful way: "4 pixels different, maximum difference per channel 1"... checking the screenshots confirms this is a visually-imperceptible antialiasing discrepancy, the sort of thing we'd just annotate as fuzzy in our reftests. Re-landing with the failures annotated on the relevant platforms.
Flags: needinfo?(jfkthame)
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/51576a3495f5 Prevent shaping across element boundaries when margin/border/padding is present, vertical-align is not 'baseline', or there is a bidi isolation boundary. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/a39aab288a00 Add WPT reftests for properties that inhibit text shaping across inline element boundaries. r=jwatt
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Backed out 2 changesets (Bug 1064172) for reftest failures in /tests/layout/reftests/css-ruby/intrinsic-isize-1.html https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=219305367 https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219305367&repo=mozilla-inbound&lineNumber=3201 [task 2018-12-30T13:10:18.464Z] 13:10:18 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-2-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:18.464Z] 13:10:18 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-2-ref.html [task 2018-12-30T13:10:18.464Z] 13:10:18 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3-ref.html [task 2018-12-30T13:10:18.464Z] 13:10:18 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3.html | 340 / 538 (63%) [task 2018-12-30T13:10:18.465Z] 13:10:18 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3-ref.html | 340 / 538 (63%) [task 2018-12-30T13:10:18.465Z] 13:10:18 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:18.466Z] 13:10:18 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-3-ref.html [task 2018-12-30T13:10:18.468Z] 13:10:18 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4-ref.html [task 2018-12-30T13:10:18.468Z] 13:10:18 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4.html | 341 / 538 (63%) [task 2018-12-30T13:10:18.468Z] 13:10:18 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4-ref.html | 341 / 538 (63%) [task 2018-12-30T13:10:18.469Z] 13:10:18 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:18.470Z] 13:10:18 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-4-ref.html [task 2018-12-30T13:10:18.471Z] 13:10:18 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5-ref.html [task 2018-12-30T13:10:18.471Z] 13:10:18 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5.html | 342 / 538 (63%) [task 2018-12-30T13:10:29.483Z] 13:10:29 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5-ref.html | 342 / 538 (63%) [task 2018-12-30T13:10:29.484Z] 13:10:29 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:29.485Z] 13:10:29 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-generation-5-ref.html [task 2018-12-30T13:10:29.485Z] 13:10:29 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1-ref.html [task 2018-12-30T13:10:29.486Z] 13:10:29 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1.html | 343 / 538 (63%) [task 2018-12-30T13:10:29.487Z] 13:10:29 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1-ref.html | 343 / 538 (63%) [task 2018-12-30T13:10:29.488Z] 13:10:29 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:29.489Z] 13:10:29 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-1-ref.html [task 2018-12-30T13:10:29.489Z] 13:10:29 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2-ref.html [task 2018-12-30T13:10:29.490Z] 13:10:29 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2.html | 344 / 538 (63%) [task 2018-12-30T13:10:29.490Z] 13:10:29 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2-ref.html | 344 / 538 (63%) [task 2018-12-30T13:10:40.409Z] 13:10:40 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:40.410Z] 13:10:40 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-2-ref.html [task 2018-12-30T13:10:40.411Z] 13:10:40 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3-ref.html [task 2018-12-30T13:10:40.412Z] 13:10:40 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3.html | 345 / 538 (64%) [task 2018-12-30T13:10:40.412Z] 13:10:40 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3-ref.html | 345 / 538 (64%) [task 2018-12-30T13:10:40.417Z] 13:10:40 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:40.417Z] 13:10:40 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-3-ref.html [task 2018-12-30T13:10:40.418Z] 13:10:40 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4-ref.html [task 2018-12-30T13:10:40.418Z] 13:10:40 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4.html | 346 / 538 (64%) [task 2018-12-30T13:10:40.418Z] 13:10:40 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4-ref.html | 346 / 538 (64%) [task 2018-12-30T13:10:40.419Z] 13:10:40 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:40.419Z] 13:10:40 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/box-properties-4-ref.html [task 2018-12-30T13:10:40.420Z] 13:10:40 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1-ref.html [task 2018-12-30T13:10:40.420Z] 13:10:40 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1.html | 347 / 538 (64%) [task 2018-12-30T13:10:40.421Z] 13:10:40 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1-ref.html | 347 / 538 (64%) [task 2018-12-30T13:10:51.436Z] 13:10:51 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:51.437Z] 13:10:51 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-1-ref.html [task 2018-12-30T13:10:51.437Z] 13:10:51 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2-ref.html [task 2018-12-30T13:10:51.438Z] 13:10:51 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2.html | 348 / 538 (64%) [task 2018-12-30T13:10:51.440Z] 13:10:51 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2-ref.html | 348 / 538 (64%) [task 2018-12-30T13:10:51.441Z] 13:10:51 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:51.442Z] 13:10:51 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-2-ref.html [task 2018-12-30T13:10:51.444Z] 13:10:51 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3-ref.html [task 2018-12-30T13:10:51.444Z] 13:10:51 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3.html | 349 / 538 (64%) [task 2018-12-30T13:10:51.448Z] 13:10:51 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3-ref.html | 349 / 538 (64%) [task 2018-12-30T13:10:51.449Z] 13:10:51 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:10:51.450Z] 13:10:51 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-insertion-3-ref.html [task 2018-12-30T13:10:51.451Z] 13:10:51 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1-ref.html [task 2018-12-30T13:10:51.452Z] 13:10:51 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1.html | 350 / 538 (65%) [task 2018-12-30T13:11:02.472Z] 13:11:02 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1-ref.html | 350 / 538 (65%) [task 2018-12-30T13:11:02.474Z] 13:11:02 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:02.475Z] 13:11:02 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-1-ref.html [task 2018-12-30T13:11:02.475Z] 13:11:02 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2-ref.html [task 2018-12-30T13:11:02.476Z] 13:11:02 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2.html | 351 / 538 (65%) [task 2018-12-30T13:11:02.476Z] 13:11:02 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2-ref.html | 351 / 538 (65%) [task 2018-12-30T13:11:02.478Z] 13:11:02 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:02.478Z] 13:11:02 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-2-ref.html [task 2018-12-30T13:11:02.479Z] 13:11:02 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3-ref.html [task 2018-12-30T13:11:02.480Z] 13:11:02 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3.html | 352 / 538 (65%) [task 2018-12-30T13:11:02.480Z] 13:11:02 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3-ref.html | 352 / 538 (65%) [task 2018-12-30T13:11:13.497Z] 13:11:13 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:13.498Z] 13:11:13 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/dynamic-removal-3-ref.html [task 2018-12-30T13:11:13.498Z] 13:11:13 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling-ref.html [task 2018-12-30T13:11:13.498Z] 13:11:13 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling.html | 353 / 538 (65%) [task 2018-12-30T13:11:13.498Z] 13:11:13 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling-ref.html | 353 / 538 (65%) [task 2018-12-30T13:11:13.502Z] 13:11:13 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:13.502Z] 13:11:13 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/float-handling-ref.html [task 2018-12-30T13:11:13.502Z] 13:11:13 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1-ref.html [task 2018-12-30T13:11:13.502Z] 13:11:13 INFO - REFTEST INFO | SET PREFERENCE pref(font.size.inflation.emPerLine,15) [task 2018-12-30T13:11:13.503Z] 13:11:13 INFO - REFTEST INFO | SET PREFERENCE pref(font.size.inflation.forceEnabled,true) [task 2018-12-30T13:11:13.503Z] 13:11:13 INFO - REFTEST INFO | SET PREFERENCE pref(font.size.inflation.lineThreshold,0) [task 2018-12-30T13:11:13.503Z] 13:11:13 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1.html | 354 / 538 (65%) [task 2018-12-30T13:11:13.503Z] 13:11:13 INFO - REFTEST INFO | RESTORE PREFERENCE pref(font.size.inflation.lineThreshold,400) [task 2018-12-30T13:11:13.503Z] 13:11:13 INFO - REFTEST INFO | RESTORE PREFERENCE pref(font.size.inflation.forceEnabled,false) [task 2018-12-30T13:11:13.504Z] 13:11:13 INFO - REFTEST INFO | RESTORE PREFERENCE pref(font.size.inflation.emPerLine,0) [task 2018-12-30T13:11:13.504Z] 13:11:13 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1-ref.html | 354 / 538 (65%) [task 2018-12-30T13:11:13.504Z] 13:11:13 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:13.504Z] 13:11:13 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/inflated-ruby-1-ref.html [task 2018-12-30T13:11:13.505Z] 13:11:13 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1-ref.html [task 2018-12-30T13:11:13.505Z] 13:11:13 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1.html | 355 / 538 (65%) [task 2018-12-30T13:11:24.524Z] 13:11:24 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1-ref.html | 355 / 538 (65%) [task 2018-12-30T13:11:24.525Z] 13:11:24 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:24.526Z] 13:11:24 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-1-ref.html [task 2018-12-30T13:11:24.528Z] 13:11:24 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2-ref.html [task 2018-12-30T13:11:24.528Z] 13:11:24 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2.html | 356 / 538 (66%) [task 2018-12-30T13:11:24.529Z] 13:11:24 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2-ref.html | 356 / 538 (66%) [task 2018-12-30T13:11:24.530Z] 13:11:24 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:24.531Z] 13:11:24 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-2-ref.html [task 2018-12-30T13:11:24.532Z] 13:11:24 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3-ref.html [task 2018-12-30T13:11:24.533Z] 13:11:24 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3.html | 357 / 538 (66%) [task 2018-12-30T13:11:24.533Z] 13:11:24 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3-ref.html | 357 / 538 (66%) [task 2018-12-30T13:11:24.534Z] 13:11:24 INFO - REFTEST TEST-PASS | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3-ref.html | image comparison, max difference: 0, number of differing pixels: 0 [task 2018-12-30T13:11:24.534Z] 13:11:24 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intra-level-whitespace-3-ref.html [task 2018-12-30T13:11:24.534Z] 13:11:24 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1-ref.html [task 2018-12-30T13:11:24.534Z] 13:11:24 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1.html | 358 / 538 (66%) [task 2018-12-30T13:11:35.550Z] 13:11:35 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1-ref.html | 358 / 538 (66%) [task 2018-12-30T13:11:35.554Z] 13:11:35 INFO - REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1-ref.html | image comparison, max difference: 255, number of differing pixels: 417 [task 2018-12-30T13:11:35.568Z] 13:11:35 INFO - REFTEST IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAgAElEQVR4nOzde5DXdb348ffuwi4IgQrJQlgBTZKpiNyCVKKiZoJRmxTzCDjVNJ1a27TG01jHW4r7M6U1cY7a1OKxvHBSCw9GioyOt0q8E4HX1UQCEm944bb7+v3R8D2se/vuxTcLPB4znz/28/18P5/X9/MZZ75P+X6+3xQAAACZpN09AAAAsO8QIAAAQDYCBAAAyEaAAAAA2QgQAAAgGwECAABkI0AAAIBs2g2QlNI+uTgPrZ8LAADorKICZF/TWoDsi/bV1w0AwPtDgLRAgPyfffV1AwDw/hAgLRAg/2dffd0AALw/OhUgzz77bFx77bWxY8eOFp/z5z//ORYuXFhYbr755njsscdaPcYzzzwT8+fPj3POOSfq6upi/fr1re7v2muvjZtvvjmefvrpoo6963Lrrbe2u81NN91UdIDs6eehs+cCAAA6q1MBMnv27EgpxdKlS1t8TlVVVZSXl8e4ceNi3Lhxccghh0SvXr1i/Pjx8c9//rPJtrW1tdGrV6+YOHFizJo1Kw455JAYMGBAkzfJ793f0KFDI6UUn//85+Pll19u89i7Ll/5ylfa3eaLX/xi0QGyp5+Hzp4LAADorA4HyOuvvx59+/aNj370ozFr1qwWn1NVVRUf+chHmqx7/vnno7KyMr7xjW8U1t19991RUlIS8+fPL6xraGiIb37zmzFgwIBYt25dq/tbtWpVHHHEETF69Oh4++232zx2MfPtqpgA2RvOQzHbCRAAALpThwPkqquuimHDhsXixYujoqIiXn311WbPae1N7WmnnRZjx44t/H3cccfFoYceGo2NjU2227hxY5SUlMQvf/nLNve3Zs2a6N27d/z85z9v99jFzLdTMQGyN5yHYrYTIAAAdKcOB8j48ePjrLPOiu3bt8cHP/jBuPLKK5s9p6U3tQ0NDXHUUUc1+deCysrKOP3001s87gMPPBDPPfdcq/vbacKECTFjxow2j13MfLsqJkD2hvNQzHYCBACA7tShAHniiScipRQrV66MiIjq6uoYN25cs+dUVVXFwIED48c//nH8+Mc/jrPOOismTJgQU6dOLXycKCKiT58+cfHFF7c7ZFtvkmfNmtVkhqqqqth///2jpqam2fL6668XtqmsrIz77ruv2bJ169Z2A2RvOQ+dPRcAANBZHQqQ6urqJh8dWrFiRaSU4sknn2zynKqqqujXr1+ceuqphWXKlClx8MEHx5IlSwrbVVRURE1NTbtDtvXG+9RTT40xY8Y02bZv374xY8aMZsuGDRsK25SUlMTAgQObLS+//HK7AbK3nIfOngsAAOisogNk69atMWjQoKiqqooVK1YUlsrKyjjzzDObPKe1N8oXXHBB9O/fPzZt2hQREf3794/zzz+/3SHbeuM9Y8aMmDx5clHbFrtNWwGyN52HYrYTIAAAdKeiA2TRokWRUoqKioomS+/eveODH/xgbNu2rfCc1t7Urly5MlJK8cc//jEiIj7+8Y/HnDlzWjxuVVVV3HbbbW3ur7GxMT760Y/G3Llz2z32e/fd2QDZm85DMdsJEAAAulPRAfKFL3whvvSlLzV7vL6+PkpKSuJ3v/tdYV1rb2rvvPPOSCnFww8/HBERZ5xxRnzgAx8o/EvATjs/0rTz9zVa219dXV2klGLZsmXtHntXXQmQvek8FLOdAAEAoDsVFSAvvvhilJaWxqJFi1rc5thjj43jjjuu8HdVVVUMGzYsVq5cGStXrownnngifvvb38bHPvaxOPLIIwv/SvCPf/wjDjrooJg2bVqsXr063n333fjzn/8chx12WBx77LHR0NDQ4v7uvffeOPvss6O8vDyqq6ubzPLebXddVq9eXdimMwGyt52Hzp4LAADorKIC5Pzzz4/9998/3n333Ra3+eUvfxm9evWK9evXR8S/3tSmlApLaWlpHHzwwfGNb3yj2S92r169Oo455pgm2x5//PHNbpTedX8DBgyIY489Nm688cZms7x3212XQYMGFbbpTIDsbeehs+cCAAA6q8O/A/J++ec//xlr1qyJN954I8vx2lLM74C8X3rSeYgQIAAAdK8eEyA9ye4MkJ5mX33dAAC8PwRICwTI/9lXXzcAAO8PAdICAfJkAAAICNgAAAABsBAQAANgICAABsBAQAANgICAAAsBEQAABgIyAAAMBGQAAAgI2AAAAAGwEBAAA2AgIAAGwEBAAA2AgIAACwERAAAGAjIAAAwEZAAACAjYAAAAAbAQEAADYCAgAAbAQEAADYCAgAALAREAAAYCMgAADARkAAAICNgAAAABsBAQAANgICAABsBAQAANgICAAAsBEQAABgIyAAAMBGQAAAgI2AAAAAGwEBAAA2AgIAAGwEBAAA2AgIAACwERAAAGAjIAAAwEZAAACAjYAAAAAbAQEAADYCAgAAbAQEAADYCAgAALAREAAAYCMgAADARkAAAICNgAAAABsBAQAANgICAABsBAQAANgICAAAsBEQAABgIyAAAMBGQAAAgI2AAAAAGwEBAAA2AgIAAGwEBAAA2AgIAACwERAAAGAjIAAAwEZAAACAjYAAAAAbAQEAADYCAgAAbAQEAADYCAgAALAREAAAYCMgAADARkAAAICNgAAAABsBAQAANgICAABsBAQAANgICAAAsBEQAABgE/SJ7weZAznYAAAAAElFTkSuQmCC [task 2018-12-30T13:11:35.584Z] 13:11:35 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1.html [task 2018-12-30T13:11:35.584Z] 13:11:35 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts [task 2018-12-30T13:11:35.584Z] 13:11:35 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot [task 2018-12-30T13:11:35.586Z] 13:11:35 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000 [task 2018-12-30T13:11:35.586Z] 13:11:35 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired [task 2018-12-30T13:11:35.586Z] 13:11:35 INFO - REFTEST INFO | Saved log: RecordResult fired [task 2018-12-30T13:11:35.586Z] 13:11:35 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1-ref.html [task 2018-12-30T13:11:35.586Z] 13:11:35 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts [task 2018-12-30T13:11:35.586Z] 13:11:35 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot [task 2018-12-30T13:11:35.586Z] 13:11:35 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000 [task 2018-12-30T13:11:35.587Z] 13:11:35 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired [task 2018-12-30T13:11:35.587Z] 13:11:35 INFO - REFTEST INFO | Saved log: RecordResult fired [task 2018-12-30T13:11:35.587Z] 13:11:35 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-ruby/intrinsic-isize-1-ref.html
Flags: needinfo?(jfkthame)
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/381c646a99e3 Backed out 2 changesets for reftest failures in /tests/layout/reftests/css-ruby/intrinsic-isize-1.html
Sigh... apparently the font being used on Android has kerning that applies at some of the element boundaries in that test. Fixed by explicitly disabling kerning (which is irrelevant to what's being tested).
Flags: needinfo?(jfkthame)
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cfc78c02568f Prevent shaping across element boundaries when margin/border/padding is present, vertical-align is not 'baseline', or there is a bidi isolation boundary. r=jwatt https://hg.mozilla.org/integration/mozilla-inbound/rev/abad2ed6d90b Add WPT reftests for properties that inhibit text shaping across inline element boundaries. r=jwatt
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/cfc78c02568f https://hg.mozilla.org/mozilla-central/rev/abad2ed6d90b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

The tests are correct, but as said on https://web-platform-tests.org/writing-tests/reftests.html:

They should also be self-describing, to allow a human to determine whether the the rendering is as expected.

I'd appreciate if you could keep that in mind for subsequent tests, it makes using them a lot easier.

Regressions: 1733276
No longer regressions: 1733276
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: