Add fromWindow() to LoadContextInfo.jsm

RESOLVED FIXED in mozilla35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Trunk
mozilla35
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Since usually consumers of the new cache have |window| in hands, there should be a shortcut to get the load context info directly from it rather then to first get nsILoadContext and use that to get nsILoadContextInfo.
(Assignee)

Comment 1

4 years ago
Created attachment 8485662 [details] [diff] [review]
v1

- added short cut to get nsILoadContextInfo (derived interface used in the networking code when nsILoadContext cannot be provided or is not enough) directly from window objects
Attachment #8485662 - Flags: review?(dolske)
(Assignee)

Comment 2

4 years ago
Created attachment 8485667 [details] [diff] [review]
v1.1

- added shortcut to get nsILoadContextInfo (derived interface used in the networking code when nsILoadContext cannot be provided or is not enough) directly from window objects
- fixed typo in LoadContextInfo.fromLoadContext: s/isPrivate/usePrivateBrowsing/, _loadContext is nsILoadContext
Attachment #8485662 - Attachment is obsolete: true
Attachment #8485662 - Flags: review?(dolske)
Attachment #8485667 - Flags: review?(dolske)
Attachment #8485667 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/e31f6893fd19
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.