1064252 - Loader doesn't flag SDK Sandbox-es with appropriate metadata

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Tomislav Jovanovic :zombie]

discovered in bug 1062024, and there is a nice and simple fix by Tom Schuster in bug 1062024 comment 2, but i'm not that familiar with the loader, so Jordan, can you please check it out?

either r+ that patch if you think it's ok, or take this bug if something more involved should be done instead?

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

If it works, sounds good to me -- can't find documentation anywhere for Cu.Sandbox's `addonId` property, so not sure what that's doing..

Comment 2

[Tomislav Jovanovic :zombie]

hey Dave, do you know anything about marking sandboxes as belonging to addons, or at least know someone who does?

Comment 3

[Dave Townsend [:mossop]]

See bug 990729

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

zombie as you volunteered to provide a patch I'm assigning this to you. If you are unable to work on this please clear priority and dis-assign and we'll find a new owner.

Comment 5

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1653

Comment 6

[Tomislav Jovanovic :zombie]

Tom Schuster did this in bug 1062024, and Gabor gave r+, so i'm just landing this to our github..

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/0137aa2e5f9a275f4ee1238d2d8ccf971b5de2fe
bug 1064252 - flag Loader Sandboxes with addonId metadata

https://github.com/mozilla/addon-sdk/commit/cbf6cdd0d630a4a450b86964106f6e93873293da
Merge pull request #1653 from zombie/1064252-loader-addonid

bug 1064252 - flag Loader Sandboxes with addonId metadata, r=Gabor