1064281 - Enhance selectors for the new about:privatebrowsing page

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Andrei Eftimie]

With the redesigned about:provatebrowsing page from bug 1009370, we've had to update our tests in bug 1059243.

One issue with the new page is a lack of identifiable elements. Some of the selectors I've had to use might be a bit brittle - we're asserting the value of localizable DTD values - a sibling selector might break if content is rearranged.

All I would like are a few extra classes on some elements to make our tests more resilient.
Affected file: https://hg.mozilla.org/mozilla-central/file/27e503753e00/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml

Specifically:
> <p class="showNormal">&aboutPrivateBrowsing.subtitle.normal;</p> // a "subtitle" class
> <p>&aboutPrivateBrowsing.description;</p> // any identification would suffice, maybe a "description" class
> <p>&aboutPrivateBrowsing.moreInfo;</p> // similar... "moreinfo"?

I don't require the class attribute, if there's a different standard we can use that (i.e. data-*)

Comment 1

[Andrei Eftimie]

Attachment: 0001-Bug-1064281-Add-a-few-classes-to-HTML-elements-on-ab.patch

Actually this seems simple enough.

I've added some classes to HTML elements that would help us identify them in automation.

Blair, I'm asking you for review since you reviewed the changes from bug 1009370.

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/380f8554aa17

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/380f8554aa17