Closed Bug 1064281 Opened 6 years ago Closed 6 years ago

Enhance selectors for the new about:privatebrowsing page

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35
Tracking Status
firefox34 --- affected
firefox35 --- affected

People

(Reporter: andrei, Assigned: andrei)

References

Details

Attachments

(1 file)

With the redesigned about:provatebrowsing page from bug 1009370, we've had to update our tests in bug 1059243.

One issue with the new page is a lack of identifiable elements. Some of the selectors I've had to use might be a bit brittle - we're asserting the value of localizable DTD values - a sibling selector might break if content is rearranged.

All I would like are a few extra classes on some elements to make our tests more resilient.
Affected file: https://hg.mozilla.org/mozilla-central/file/27e503753e00/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml

Specifically:
> <p class="showNormal">&aboutPrivateBrowsing.subtitle.normal;</p> // a "subtitle" class
> <p>&aboutPrivateBrowsing.description;</p> // any identification would suffice, maybe a "description" class
> <p>&aboutPrivateBrowsing.moreInfo;</p> // similar... "moreinfo"?

I don't require the class attribute, if there's a different standard we can use that (i.e. data-*)
Blocks: 1064285
Actually this seems simple enough.

I've added some classes to HTML elements that would help us identify them in automation.

Blair, I'm asking you for review since you reviewed the changes from bug 1009370.
Assignee: nobody → andrei.eftimie
Status: NEW → ASSIGNED
Attachment #8485744 - Flags: review?(bmcbride)
Attachment #8485744 - Flags: review?(bmcbride) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/380f8554aa17
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.