1064315 - [camera] Update gaia-header and gaia-icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Wilson Page [:wilsonpage]]

Camera app currently handles the the gaia-icons dependency locally. There is a risky that startup will regress with this approach as fast font loading requires that the font requested matches that in the system.

If we switch to pull gaia-icons from shared, we can guarantee that Camera will always get fast font loading.

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 2

[Wilson Page [:wilsonpage]]

I've decided for the time being to simply update gaia-icons and gaia-header to keep Camera decoupled from gaia/shared. If we find it troublesome to stay in sync then we may have to rethink this.

The good news is that we are seeing a considerable startup performance improvement when Camera uses the same (pre-loaded) gaia-icons font in shared/elements/.

We just have to make sure the owners of gaia-icons (currently me) know that when they update gaia-icons in shared, they will also have to update the apps that have gaia-icons installed locally.

Comment 3

[Wilson Page [:wilsonpage]]

Comment on attachment 8486570 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/32bdf4a18cc8f2f8bc65206ab8393aeb0278f385

Comment 4

[Wilson Page [:wilsonpage]]

[Blocking Requested - why for this release]: Brings style and performance improvements.

Comment 5

[Wilson Page [:wilsonpage]]

Comment on attachment 8486570 [details] [review]
pull-request (master)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Slower startup, some style inconsistency
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/8a6c37aa4b8f006c563925c95afd2afb6588b1d7