Closed Bug 1064327 Opened 10 years ago Closed 10 years ago

The SHB is displayed for apps with fullscreen_layout:true... even when the Software Home Button is disabled :/

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: etienne, Assigned: Eli)

References

Details

(Keywords: polish, Whiteboard: [systemsfe])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23913
46 bytes, text/x-github-pull-request
etienne
: review+
bajaj
: approval-gaia-v2.1+
Details | Review 
STR:

* add "fullscreen_layout":true to the manifest of the UITests app (or other)
* disable the software home button
* launch the UITests app

Expected:
* the app should display normally

Actual:
* a non-functional software home button is overlayed on the app

It's probably a simple fix, where we're missing a `#screen.software-button-enabled` on a rule.
Blocks: soft-home-button
Blocks: 1055198
Blocks: 1054126
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Whiteboard: [systemsfe]
Assignee: nobody → eperelman
Status: NEW → ASSIGNED
Target Milestone: --- → 2.1 S4 (12sep)
Removing from meta as this is not a blocker for 2.1.
No longer blocks: soft-home-button
Comment on attachment 8487237 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23913

:)
Attachment #8487237 - Flags: review?(etienne) → review+
Keywords: checkin-needed, polish
Master: https://github.com/mozilla-b2g/gaia/commit/d4884e6de9d9bece923d8f985775ee3843ef096a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 8487237 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23913

Requesting uplift to v2.1 for feature polish.

[Bug caused by] (feature/regressing bug #): bug 1036339
[User impact] if declined: buggy SHB for fullscreen_layout apps
[Testing completed]: yes, manual
[Risk to taking this patch] (and alternatives if risky): super low, only single CSS change
[String changes made]: n/a
Attachment #8487237 - Flags: approval-gaia-v2.1?
Attachment #8487237 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
The issue is verified fixed in Flame 2.1 and Flame 2.2:

Flame 2.1 KitKat Base (319mb)(Shallow Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141008000201
Gaia: d71f8804d7229f4b354259d5d8543c25b4796064
Gecko: 7fa82c9acdf2
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2 KitKat Base (319mb)(Shallow Flash)

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141008040203
Gaia: 0bc74ce502672cf0265b24cf3a25d117c3de5e71
Gecko: e4cfacb76830
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The software home button was not appearing in an app when "fullscreen_layout":true was added to the manifest.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.1: fixed → verified
status-b2g-v2.2: fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: