Closed Bug 1064451 Opened 6 years ago Closed 6 years ago

Convert assertion-expression-type checking code to not perform a function call

Categories

(Core :: MFBT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Debugging past assertions is obnoxious these days, due to the brief descent into the method that just static_asserts the condition type isn't dumb.  Just nest the assertions in a class and instantiate that instead.
Comment on attachment 8485897 [details] [diff] [review]
Patch

Review of attachment 8485897 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray for build-time checks.  I'm going to assume that the Windows build bustage on your try push was from a busted base revision.
Attachment #8485897 - Flags: review?(nfroyd) → review+
Summary: Convert assertion-expression-type checking code to not perform a function call. NOT REVIEWED YET → Convert assertion-expression-type checking code to not perform a function call
https://hg.mozilla.org/mozilla-central/rev/ff274222817c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.