Convert assertion-expression-type checking code to not perform a function call

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla35
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Debugging past assertions is obnoxious these days, due to the brief descent into the method that just static_asserts the condition type isn't dumb.  Just nest the assertions in a class and instantiate that instead.
Comment on attachment 8485897 [details] [diff] [review]
Patch

Review of attachment 8485897 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray for build-time checks.  I'm going to assume that the Windows build bustage on your try push was from a busted base revision.
Attachment #8485897 - Flags: review?(nfroyd) → review+
Summary: Convert assertion-expression-type checking code to not perform a function call. NOT REVIEWED YET → Convert assertion-expression-type checking code to not perform a function call
https://hg.mozilla.org/mozilla-central/rev/ff274222817c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.