Closed
Bug 1064451
Opened 10 years ago
Closed 10 years ago
Convert assertion-expression-type checking code to not perform a function call
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Debugging past assertions is obnoxious these days, due to the brief descent into the method that just static_asserts the condition type isn't dumb. Just nest the assertions in a class and instantiate that instead.
|
Assignee | |
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8775a5f4b9e6
Attachment #8485897 -
Flags: review?(nfroyd)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8485897 [details] [diff] [review] Patch Review of attachment 8485897 [details] [diff] [review]: ----------------------------------------------------------------- Hooray for build-time checks. I'm going to assume that the Windows build bustage on your try push was from a busted base revision.
Attachment #8485897 -
Flags: review?(nfroyd) → review+
|
|
||
Updated•10 years ago
|
Summary: Convert assertion-expression-type checking code to not perform a function call. NOT REVIEWED YET → Convert assertion-expression-type checking code to not perform a function call
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff274222817c
Flags: in-testsuite-
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ff274222817c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•