1064485 - [Search] Clearing Rocketbar search still displays results for last search term

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot - Previous Search Term "Jump"

Description:
With search results enabled, clearing search term by pressing "x" icon after searching for a term in Rocketbar still displays results for cleared search term.

Repro Steps:
1) Update a Flame device to BuildID: 20140908000204
2) Tap Rocketbar
3) Type search term
4) After results appear select "x" icon to clear search term
  
Actual:
Search results do not disappear along with keyword/search term.

Expected: 
Search results disappear along with keyword/search term.

Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
Repro frequency: 3/3, 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/13926/
See attached: screenshot & logcat

Comment 1

[Brogan Zumwalt [Inactive]]

Issue DOES occur on Flame 2.2 (319mb), OpenC 2.2, Flame 2.1 (512mb), and OpenC 2.1

Device: Flame Master (319mb)
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Open_C Master 
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1(512mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Open_C 2.1 
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Actual Result: Search results do not disappear along with keyword/search term.


Issue does NOT occur on Flame 2.0 (319mb) or OpenC 2.0

Device: Flame 2.0 (319mb)
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Open_C 2.0 
Build ID: 20140908000202
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Actual Result: Search results disappear along with keyword/search term.

Comment 2

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Comment 3

[Marcia Knous [:marcia]]

Can you repro this consistently? I just tried on Flame and wasn't able to repro:

Gaia   a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
SourceStamp 746f24f9d21d
BuildID 20140908000204
Version 34.0a2
v. 123

Comment 4

[Brogan Zumwalt [Inactive]]

Successfully reproduced issue on multiple devices on same build that you are using Marcia. Checked again just now and issue still reproduces.

Comment 5

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8486164 [details] [review]
Pull request

So I don't think I can R+ this without seeing if we can fix some of the repercussions of the patch which I think are worse. Currently with this patch, the next keystroke will cause the old results to flash, I think we should try to fix this.

It would be much better if we can go through the clear() path in search.js, here: https://github.com/mozilla-b2g/gaia/blob/master/apps/search/js/search.js#L276

Do you think this is possible?

Comment 7

[Sherman Chen [:chens] (inactive)]

I'm not able to reproduce the flashing. Is it occurs when typing keyword to search? or it occurs after hit the clear button and start over a new search? Providing a video to explain my findings [1], on the left hand side is master w/ patch, and right hand side is master (6ff857140361989a2bf11f203f49e074aa85aed3)

[1] http://youtu.be/EwryVzc0FQ4

Comment 8

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request 2

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8486247 [details] [review]
Pull request 2

This is better and removes the flashing for me. Thanks!

Comment 10

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/3d217a21787ba456ce28438ce9f030f12e957358

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8486247 [details] [review]
Pull request 2

This is a small patch with a nice improvement for UX that we should be able to safely get into 2.1.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Less than ideal UX, clearing the results will leave them on the screen.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, simple patch and contained to only a new feature.
[String changes made]: None.

Comment 12

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Not nominating this as a blocker. If the user starts another search, the search results will be updated with the new search

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/c427e5ced47ccdaf4739d55b28ac3f4ff9450611

Comment 14

[Elie]

Attachment: VIDEO0058.mp4

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.2:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2

Comment 15

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.1 & 2.2.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/20

Flame v2.1 version:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0

Flame 2.2 version:
Gaia-Rev        41b7be7c67167f367c3c4982ff08651d55455373
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/ff4a63d66806
Build-ID        20141126160201
Version         36.0a1