"Name" and "Accepting new members" strings is cannot be localized

VERIFIED FIXED

Status

Participation Infrastructure
Phonebook
--
minor
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: YF (Yang), Assigned: Jérémy Dagorn)

Tracking

(Blocks: 1 bug)

2014-12.6

Details

(Whiteboard: [kb=1581371] [good first bug])

(Reporter)

Description

4 years ago
These strings not in po files.

Examples:
https://mozillians.org/en-US/groups/add/
https://mozillians.org/zh-CN/groups/add/
Whiteboard: [good first bug]
Thanks for submitting this bug YF! Good find.
(Assignee)

Comment 2

4 years ago
I would like to take this bug, as it would help me make my way in the codebase. Is it OK?
Of course it is :)
Thanks for offering to help. I am assigning this bug to you.
You can find useful information on how to setup your local environment here [0]. Also if you need additional help you can always ask at #commtools on irc.

[0] http://mozillians.readthedocs.org/en/latest/
Assignee: nobody → jeremy.dagorn
Status: NEW → ASSIGNED
Whiteboard: [good first bug] → [kb=1581371] [good first bug]

Comment 4

4 years ago
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/1e3c5c7cdcff38a5c4d50ea118e6e37ae8ab6ce1
[Fix bug 1064486] Localize strings in add group page.

https://github.com/mozilla/mozillians/commit/efd6cc811d786ecff25826232e5cb5b918d39813
Merge pull request #1126 from johngian/pr-1123

[Fix bug 1064486] Localize strings in add group page.

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Version: other → next
Browsers:
-Firefox/Mac
-Chrome/Mac

I can verify the following for this bug:

1. My thinking for this bug is that the translation team will need to verify that they will now see 'Name' and 'Accepting new members' fields translated when they use they correct translation file. I am unable to see the fields translated, but I believe it's because I don't have the correct file perhaps.

2. In addition, I noticed that the 'IRC' field is also not getting translated, so it would be good if that field is fixed as well. I will file a new bug for this.

3. For this bug, I can verify that the following has been changed in the code
https://github.com/mozilla/mozillians/commit/1e3c5c7cdcff38a5c4d50ea118e6e37ae8ab6ce1#diff-9e19e76fd73ce35e4918a3fc9bc96cbbR76
{% if user.userprofile.is_manager %}
- <h2>Admin Settings</h2>
+ <h2>{{ _('Admin Settings') }}</h2>

https://github.com/mozilla/mozillians/commit/1e3c5c7cdcff38a5c4d50ea118e6e37ae8ab6ce1
class GroupBase(models.Model):
- name = models.CharField(db_index=True, max_length=50, unique=True)
+ name = models.CharField(db_index=True, max_length=50,
+ unique=True, verbose_name=_lazy(u'Name'))
url = models.SlugField(blank=True)
objects = GroupBaseManager()
@@ -176,6 +177,7 @@ class Group(GroupBase):
default='', blank=True)
members_can_leave = models.BooleanField(default=True)
accepting_new_members = models.CharField(
+ verbose_name=_lazy(u'Accepting new members'),
choices=(
('yes', _lazy(u'Yes')),
('by_request', _lazy(u'By request')),
Flags: needinfo?(yfdyh000)
 Bumping to verified per comment 5 -- YF are able to verify that this meets your needs?
Status: RESOLVED → VERIFIED
(Assignee)

Comment 7

4 years ago
Anything I should do then?
(Reporter)

Comment 8

4 years ago
I don't see it been updated at https://svn.mozilla.org/projects/l10n-misc/trunk/mozillians/locales/en_US/LC_MESSAGES/messages.po.

These still can not be localized via Mozilla Verbatim at the moment.
Status: VERIFIED → REOPENED
Flags: needinfo?(yfdyh000)
Resolution: FIXED → ---
(Assignee)

Comment 9

4 years ago
I am the one working on this bug. I committed the changes. Is there anything I should do? or ask someone to run a script to make them appear on the .po file?
(Assignee)

Comment 10

4 years ago
Edit: I know that locally I was running a script that made them appear in the .po file and was able to play with the translation, verifying that it worked. http://mozillians.readthedocs.org/en/latest/internationalization.html#managing-strings
I merged some new strings and Verbatim is up-to-date. These strings should be available for localization now.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago3 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Version: next → 2014-12.6
You need to log in before you can comment on or make changes to this bug.