Closed Bug 1064503 Opened 7 years ago Closed 5 months ago

Visual indication of checkbox focus lost when zooming

Categories

(Core :: Widget: Win32, defect, P3)

31 Branch
x86_64
Windows 7
defect

Tracking

()

RESOLVED DUPLICATE of bug 1050753

People

(Reporter: sodomsky, Unassigned)

References

(Blocks 1 open bug)

Details

(4 keywords, Whiteboard: tpi:+)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140716183446

Steps to reproduce:

Set windows magnification to 100%(Control Panel\Appearance and Personalization\Display)

Focus on checkbox and zoom in(higher magnification) within Firefox.



Actual results:

The visual focus on the checkbox disappears when zooming in(higher magnification)


Expected results:

Visual focus should remain present.
Can you provide a screenshot? How are you zooming in - using Firefox's built-in zoom, or the Windows tools?
Flags: needinfo?(sodomsky)
Example to reproduce:
Launch Firefox
Open a Bugzilla report form (I reproduced on the checkbox in this Bugzilla report).
Go to View menu, Zoom> disable "Zoom Text Only"
Tab to the checkbox labeled "CC List" - the dotted focus is visible around 2 sides of the checkbox.



Running Windows 7 Professional SP1 (64bit v1.06.00.AE B07), Firefox ESR 31.4.0
Continued comments (sorry, my changes were saved before I could finish) - to repeat my previous comments.

Example to reproduce:
1. Launch Firefox
2. Open a Bugzilla report form (I reproduced on the checkbox in this Bugzilla report).
3. Go to View menu> Zoom> disable "Zoom Text Only"
4. Tab to the checkbox labeled "CC List" - you will see the dotted focus is visible around 2 sides of the checkbox.
5. Press Cntrl++ once. Or, use the View> Zoom> Zoom In option. This will increase the text size slightly.
Problem:  the dotted focus disappears.

FYI: The check box on the Bugzilla form has a nice blue outline for a secondary visible focus indicator. However, this is an Accessibility problem (WCAG 2.0 1.4.4) for users who need the use of Large Text and they are using an application that rely upon the default dotted focus.

I am running Windows 7 Professional SP1 (64bit v1.06.00.AE B07), Firefox ESR 31.4.0
Diane: thanks for the detailed explanation, that really helps!

Drew, do you know if this kind of issue is tracked already and/or if not, who knows about the internals of our zoom code? (is it :kats ? )

(not tried to reproduce for now, needinfo'ing myself for that - in theory it could have been fixed since ESR 31, I guess?)
Flags: needinfo?(sodomsky)
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(adw)
Keywords: access
Product: Firefox → Core
There's probably no way this is a front-end bug, but I couldn't reproduce it in my Windows 7 VM.  Actually what I see is a larger blue highlight around the checkbox, and then within that only on the right and bottom sides, there are dotted lines.  That doesn't change when I zoom.

We should probably ask someone on the layout team, probably Olli?  Here's the current blame for SetFullZoom: http://hg.mozilla.org/mozilla-central/annotate/0467412f8413/layout/base/nsDocumentViewer.cpp#l2992
Flags: needinfo?(adw)
In addition to needing the FF "Zoom Text Only" option disabled, I just discovered more information to make this problem occur:
The Windows Control Panel "Display" setting must be set to "Smaller 100%". This is the default setting.
I tested both 125% & 150%, and the visible focus is okay.

Here is how to find the Control Panel setting:
Windows 7 Control Panel> Appearance & Personalization> Display.  There is a set of radio buttons to control the size of text & other options on your screen (Smaller 100%, Medium 125%, Larger 150%). Select Smaller.
(In reply to Drew Willcoxon :adw from comment #5)
> There's probably no way this is a front-end bug, but I couldn't reproduce it
> in my Windows 7 VM.  Actually what I see is a larger blue highlight around
> the checkbox, and then within that only on the right and bottom sides, there
> are dotted lines.  That doesn't change when I zoom.

I see the same thing here, both with and without text zoom disabled, and with the Display setting at 100%.


Diane, can you test on a more recent version of Firefox than 31ESR , and provide a screenshot from those versions of Firefox?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(dianevm)
Hi, I don't have access to a higher version of ESR - I am limited to my work place environment. I will let you know if that status changes. Let me know if you need a screen shot of the issue, using my current environment. I could post it on Monday 2/2 if you need it.
Flags: needinfo?(dianevm)
(In reply to Diane M from comment #8)
> Hi, I don't have access to a higher version of ESR - I am limited to my work
> place environment. I will let you know if that status changes. Let me know
> if you need a screen shot of the issue, using my current environment. I
> could post it on Monday 2/2 if you need it.

Yes please!
Flags: needinfo?(dianevm)
More information:
I just took snapshots of the issue and magnified in Paint (so that you can really see the check box). I discovered that the dotted check box outline is STILL there after you increase the Firefox text size, but the color of the dotted outline changes to WHITE. In your bug form, under magnification the dotted outline IS detectable due to the blue background. In the application I am testing, the white dotted outline cannot be seen because the outline is the same color as the background (white). You can think about that during the weekend.

I will create image files on 2/2 and post for you to see.
Flags: needinfo?(dianevm)
For details, refer to my previous comments in the bugzilla report.
For details, refer to my previous comments in the bugzilla report.
Hi Diane, 

I have tested the mentioned issues on latest Firefox ESR release (38.5.2) and I could not reproduce it. Before and after Text Zoom the checkbox appears properly.

Firefox: 38.5.2, Build ID: 20151221154602, User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0

Can you please test this on the latest Firefox release 38.5.2 (https://www.mozilla.org/en-US/firefox/organizations/all//) and tell me if this still reproduces for you? When doing this please use a new fresh Firefox profile, maybe also in safe mode (https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems). 

Thanks,
Cosmin.
Flags: needinfo?(sodomsky)
Hi Cosmin, Thanks for looking at this bug.

- I can repro using IBM corp laptop running FF ESR v38.5.2, and 
- I can repro using my personal computer with FF 48 (non-ESR) on Vista. At this point, it would be difficult for me to my IBM environment. Therefore, I would like to confirm your experience. Would you please open the link below* & use the steps to reproduce (I will paste them again here) and then attach a snapshot so that I can inspect what you are seeing? 
 
The reason why I ask:  it would be very easy to think the problem is not reproducible if you test a web page using a non-white background or test a checkbox that has a secondary colored visual focus indicator.

*This page has a white background & does not use a blue focus highlight around the checkbox:
http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_input_checked

Steps to repro:
1. The Windows Control Panel "Display" setting must be set to "Smaller 100%" (if you have this setting). 
2. Launch Firefox
3. Open link provided
4. Go to View menu> Zoom> disable (no checkmark) "Zoom Text Only"
5. Tab to one of the checkboxes in the sample - you will see the dotted focus is visible around 2 sides of the checkbox (it is a white dotted line on the gray checkbox outline).
5. Press Cntrl++ once. Or, use the View> Zoom> Zoom In option. This will increase the text size slightly.
Problem:  the dotted white focus moves away from the checkbox outline & onto the white background (not visible).
Thanks for the quick reply, Diane.

I'm really not sure why I didn't see this before, but I can totally reproduce with your steps from comment #14 on my Windows 8.1 machine.

It seems like the focus rectangle is rendered without taking the zoom level into account.

Kats, do you have any idea what's wrong here and/or where this goes? Tentatively moving to Layout for now, but it's possible it belongs somewhere else / more specific...
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Component: Untriaged → Layout
Ever confirmed: true
Flags: needinfo?(sodomsky) → needinfo?(bugmail.mozilla)
I can't reproduce this problem on Linux (testing with today's Nightly), but I can reproduce a problem that might be related:

  1. Set browser to 100% zoom
  2. Load http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_input_checked
  3. Tab to give focus to the first checkbox. The dotted focus rect appears around it.
  4. Press Tab one more time to move focus to the second checkbox.
       --> The dotted focus rect remains around the first checkbox.
  5. Zoom in (Ctrl++). _Now_ the focus rect moves to the second checkbox.
  6. In the zoomed-in state, Tab and Shift+Tab move the focus rect immediately, but
     sometimes 1 or 2 sides of the rect are missing.
Assuming this is a regression, a regression window would be helpful.
The dotted border appears to be drawn by nsITheme::DrawWidgetBackground(), called by content-side painting routines with an nsGfxCheckboxControlFrame as an argument. At least in the situation I can reproduce (described in comment 16), the parameters passed to this method seem reasonable, so it's not clear yet where the problem lies.

The issue doesn't have any relation to APZ, so I'm clearing the needinfo on kats and cc'ing some Layout people.
Flags: needinfo?(bugmail.mozilla)
Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c66a7e1fdf2&tochange=d9d4bf676f65

I won't be able to narrow it down any further most likely. Hopefully someone else sees a plausible-looking candidate in that range.

Basically, the old behavior was that all four sides had a dotted outline and that outline grew with the zoom level (but not the checkbox size!), and the new behavior started occurring once the checkbox styling changed.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #19)
> Regression range:
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=4c66a7e1fdf2&tochange=d9d4bf676f65

(Wow, a 2009 regression range! Guess we've had this bug for a while.)
Bug 478147 sounds related.
Blocks: 478147
Jim, any chance you can take a look at this?
Flags: needinfo?(jmathies)
sure, I can try to take a look. This is pretty polishy though so not a huge priority for me.
Flags: needinfo?(jmathies)
Assignee: nobody → jmathies
Component: Layout → Widget: Win32
Blocks: themea11y
Priority: -- → P2
Whiteboard: tpi:+
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Assignee: jmathies → nobody
No longer blocks: themea11y
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1050753
You need to log in before you can comment on or make changes to this bug.