Closed Bug 1064555 Opened 10 years ago Closed 9 years ago

uglify2 errors when doing 'make production'

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: jhirsch, Unassigned)

Details

While investigating bug 1058978, I noticed that `make production`, which enables Uglify2 for the Settings app, throws a bunch of errors: Error: Cannot uglify2 file: /Users/jhirsch/codez/github/mozilla-b2g-gaia/build_stage/settings/js/modules/apn/apn_settings_manager.js. Skipping it. Error is: Unexpected token: operator (>) (line: 452, col: 40, pos: 12348) Error: Cannot uglify2 file: /Users/jhirsch/codez/github/mozilla-b2g-gaia/build_stage/settings/js/panels/apn_editor/apn_editor_const.js. Skipping it. Error is: Unexpected token: operator (>) (line: 36, col: 44, pos: 790) Error: Cannot uglify2 file: /Users/jhirsch/codez/github/mozilla-b2g-gaia/build_stage/settings/js/panels/apn_editor/panel.js. Skipping it. Error is: Unexpected token: operator (>) (line: 83, col: 37, pos: 2878) Error: Cannot uglify2 file: /Users/jhirsch/codez/github/mozilla-b2g-gaia/build_stage/settings/js/panels/app_permissions_detail/panel.js. Skipping it. Error is: Unexpected token: punc ()) (line: 220, col: 53, pos: 7179) Error: Cannot uglify2 file: /Users/jhirsch/codez/github/mozilla-b2g-gaia/build_stage/settings/shared/js/download/download_store.js. Skipping it. Error is: Unexpected token: operator (>) (line: 113, col: 35, pos: 2436) Error: Cannot uglify2 file: /Users/jhirsch/codez/github/mozilla-b2g-gaia/build_stage/settings/shared/js/omadrm/fl.js. Skipping it. Error is: Name expected (line: 129, col: 12, pos: 4581) I suspect these could be fixed by having uglify do less uglification (maybe leaving the line breaks), or by manually adjusting each of these individual files in turn. Any thoughts on which approach would be better?
Hi Jared Hirsch, The same issue appears in the process of building the project. Do you know how to fix this bug?
Flags: needinfo?(6a68)
Hi Chaochao, I'm sorry, but I don't recall what the fix was for this bug. Maybe try `make clean && make really-clean`, or email dev-gaia if that doesn't work. Good luck! Jared
Flags: needinfo?(6a68)
can't reproduce on master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.