Closed Bug 1064565 Opened 10 years ago Closed 10 years ago

/report/list/ in the middleware is called excessively

Categories

(Socorro :: Webapp, task)

Product:
Socorro
Component:
Webapp
Platform:
x86
macOS
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: peterbe, Assigned: peterbe)

Details

Now that we have the ability to measure what's going on in the middleware, I did a BUNCH of local clicks on signatures to try to gauge a rough idea where most of the time is spent in the middleware. Basically, I clicked a bunch of signatures from the Top Crashers. Here are the results::

MEDIAN         TOTAL          AVERAGE        TIMES          PATH
5452.53        142.02203      4.73406766667  30             /report/list/
2396.98        53.29412       3.55294133333  15             /signaturesummary/
1358.92        25.13461       1.67564066667  15             /crashes/comments/
868.03         14.56794       0.971196       15             /signatureurls/
471.54         0.47154        0.47154        1              /products/
244.77         5.36236        0.357490666667 15             /crashes/frequency/
226.44         3.34169        0.222779333333 15             /crashes/adu_by_signature/
144.14         2.16396        0.144264       15             /bugs/
8.69           1.52465        0.046201515151533             /correlations/

What's crucial to note is that the /report/list/ path is executed twice as many times as all the other tabs.

Upon closer inspection the only difference between these, in the full query string, is that one has an additional "sort=date_processed" that the other one doesn't. Thus, it's not able to reuse the local cache.
Summary: /report/list/... in the middleware is called excessively → /report/list/ in the middleware is called excessively
In the above measurements, the excessive calls to /report/list/ constitutes about 30%(!) of the total data retrieval time and this can be solved by fixing the "sort=date_processed" thing.
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/33c038ea246357fbed98b18821b27f186489890b
fixes bug 1064565 - /report/list/ in the middleware is called excessively

https://github.com/mozilla/socorro/commit/6a985b1cd465ea992d5e84bdaa1972c6e0f9717a
Merge pull request #2342 from peterbe/bug-1064565-reportlist-in-the-middleware-is-called-excessively

fixes bug 1064565 - /report/list/ in the middleware too often
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102
You need to log in before you can comment on or make changes to this bug.