1064613 - Move server-side account deletion block in _handleGetAssertionError()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Sam Penrose]

The current logic looks like this:

if (our token is invalid) { // 1
  return a Promise(
    if (the account exists) { // 2
      demand correct password 
    }
    // 3 silent null
  )
  signOut() and require login // 4
}
Option 4 needs to move to location 3.

Comment 1

[Sam Penrose]

Attachment: 1064613-handle-deleted.patch

Could you take a look at this Fernando? If you want to run xpcshell-test (entirely up to you), it requires the patch from bug 1064606 , as well as tricking mach. Thanks very much!

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8486110 [details] [diff] [review]
1064613-handle-deleted.patch

Thanks Sam, good catch!

Comment 3

[Sam Penrose]

https://tbpl.mozilla.org/?tree=Try&rev=9fd384717fd9

Comment 4

[Sam Penrose]

[Blocking Requested - why for this release]: Fixes case where server-side account deletion will throw FxA error; user gets clean "Please sign in" flow.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6638ccdc5587

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6638ccdc5587

Comment 7

[Dietrich Ayala (:dietrich)]

Triage reviewed, marked blocking- because it's not a regression and not a common user scenario. Please ask for approval on the patch to land. And renominate if this is so critical we cannot ship 2.1 without it.