1064634 - Considering adjusting media thread stack size on all platforms

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Following on from the change in bug 1062596 to increase OS X's media thread stack size from 128kB to 256kB, I wonder if we'd be better served trying to keep the media thread stack size the same on all platforms to avoid unnecessary divergence.  Since we know OS X requires at least 256kB, my proposal is to increase the other platforms to the same value.

I think the stack size matters less now cpearce has reduced the number of media threads active (and there's another thread per element to remove in bug 750596).  The effect of bug 973705 (decode thread pool size) needs to be considered too.

ni? cpearce for his thoughts since he's been closest to this

Comment 1

[Matthew Gregan [:kinetik]]

CCing Jean-Yves since he worked on bug 1062596 and may have thoughts also.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

I don't think it would hurt to bring our thread stack sizes into line across platforms.

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Use the same media thread stack size on all platforms where we specify a size. Also document the rationale behind the MOZ_ASAN exception

Comment 4

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=6834802a3a72

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51769c116f41

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/51769c116f41