1064674 - Mochitest for Bug 1063971 using non-spec set(Local|Remote)Description wo/callbacks

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: mochitest for non-spec set(Local|Remote)Description wo/callbacks.

Try before Bug 1063971 patch: https://tbpl.mozilla.org/?tree=Try&rev=93198b9462bb
Try after  Bug 1063971 patch: https://tbpl.mozilla.org/?tree=Try&rev=d7c31af8b353

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Anything else needed for review on this one?

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8486186 [details] [diff] [review]
mochitest for non-spec set(Local|Remote)Description wo/callbacks.

Review of attachment 8486186 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/tests/mochitest/pc.js
@@ +1737,5 @@
> +
> +    if (!onSuccess) {
> +      this._pc.setLocalDescription(desc);
> +      return;
> +    }

NIT: I would have preferred an '} else {' here to help understanding the two cases a little easier.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: mochitest for non-spec set(Local|Remote)Description wo/callbacks (2) r=jesup, dnro

Incorporated feedback. Carrying forward r=jesup, drno.

Try - https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d42d379cb63a

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: mochitest for non-spec set(Local|Remote)Description wo/callbacks (3) r=jesup, dnro

Add bug # to commit msg. Carrying forward r=jesup, drno.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5655230b19de

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5655230b19de