Closed Bug 1064698 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\mail\base\test\unit\test_windows_font_migration.js | test failed (with xpcshell return code: 0)

Categories

(Thunderbird :: Migration, defect)

Product:
Thunderbird
Component:
Migration
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird34 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 35.0
Tracking Flags:
Tracking Status
thunderbird34 --- fixed

People

(Reporter: hiro, Assigned: standard8)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

The fix
5.31 KB, patch
jcranmer
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
22:39:28  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\mail\base\test\unit\test_windows_font_migration.js | test failed (with xpcshell return code: 0), see following log:
22:39:28     INFO -  >>>>>>>
22:39:28     INFO -  TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 54] "Times New Roman" == "Times New Roman"
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 56] "Arial" == "Arial"
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 58] "Courier New" == "Courier New"
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 60] 16 == 16
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 62] 13 == 13
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 54] "Times New Roman" == "Times New Roman"
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 56] "Arial" == "Arial"
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 58] "Courier New" == "Courier New"
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 60] 16 == 16
22:39:28     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js | [verifier : 62] 13 == 13
22:39:28  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell/head.js | NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref] - See following stack:
22:39:28     INFO -  JS frame :: C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js:54 :: verifier :: line 0
22:39:28     INFO -  JS frame :: test_migrating_all_prefs@C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js:154:2
22:39:28     INFO -  JS frame :: C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/test_windows_font_migration.js:387 :: run_test :: line 6
22:39:28     INFO -  JS frame :: _execute_test@C:\\slave\\test\\build\\tests\\xpcshell\\head.js:403:4
22:39:28     INFO -  JS frame :: -e:1 :: anonymous :: line 0
22:39:28     INFO -  <<<<<<<
22:39:28     INFO -  TEST-INFO | C:\slave\test\build\tests\xpcshell\tests\image\test\unit\test_async_notification.js | running test ...
22:39:29     INFO -  TEST-PASS | C:\slave\test\build\tests\xpcshell\tests\image\test\unit\test_async_notification.js | test passed (time: 206.000ms)
22:39:29     INFO -  TEST-INFO | C:\slave\test\build\tests\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_417798.js | running test ...
22:39:30  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_417798.js | test failed (with xpcshell return code: 0), see following log:
(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> C:/slave/test/build/tests/xpcshell/tests/mail/base/test/unit/
> test_windows_font_migration.js:54 :: verifier :: line 0
> 22:39:28     INFO -  JS frame ::
> test_migrating_all_prefs@C:/slave/test/build/tests/xpcshell/tests/mail/base/
> test/unit/test_windows_font_migration.js:154:2

test_windows_font_migration.js:
154   aVerifier("x-central-euro", null);

There is no "font.serif.x-central-euro" in preferences.
We need to port bug 756022?
Keywords: intermittent-failure
Joshua may have an idea here.
I don't know what x-central-euro did or didn't correspond to, but it's possible it doesn't correspond to any font nowadays.
(In reply to Joshua Cranmer [:jcranmer] from comment #3)
> I don't know what x-central-euro did or didn't correspond to, but it's
> possible it doesn't correspond to any font nowadays.

All Latin font prefs were unified to x-western in bug 756022. x-central-euro no longer exists in Gecko.

x-central-euro meant iso-8859-2/windows-1250-affiliated languages: Polish, Czech, etc.
Component: Untriaged → Migration
Assignee: nobody → standard8
Attached patch The fix — — Splinter Review 
This fixes the failures - since the encoding types have been merged with x-western, I think it makes sense just to remove them.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=05c698680313
Attachment #8490638 - Flags: review?(Pidgeot18)
Comment on attachment 8490638 [details] [diff] [review]
The fix

Review of attachment 8490638 [details] [diff] [review]:
-----------------------------------------------------------------

Another question is how old this migration is and whether we still need to facilitate the migration.
Attachment #8490638 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/e885bc1e385d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 35.0
Comment on attachment 8490638 [details] [diff] [review]
The fix

[Triage Comment]
Taking to aurora to fix failures there as well.
Attachment #8490638 - Flags: approval-comm-aurora+
Comment on attachment 8490638 [details] [diff] [review]
The fix

Review of attachment 8490638 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Joshua Cranmer [:jcranmer] from comment #29)
> Another question is how old this migration is and whether we still need to
> facilitate the migration.
It landed for Thunderbird 3.1 beta 2, Thunderbird got released on 20100624.

::: mail/base/test/unit/test_windows_font_migration.js
@@ -252,2 @@
>    Services.prefs.setIntPref("font.size.fixed.el", 70);
>    Services.prefs.setIntPref("font.size.variable.tr", 80);

Is there a reason why this line hasn't been removed?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: