Closed
Bug 1064709
Opened 10 years ago
Closed 10 years ago
Theme settings panel should use 'data-icon' instead of classes to define it's icon
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: olle.klang, Unassigned)
References
Details
Attachments
(1 file)
A small fix to update the themes panel to use data-icon instead of classes.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8486250 -
Flags: review?(ehung)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8486250 [details] [review] pull-request See comment on Github. Thanks.
Attachment #8486250 -
Flags: review?(ehung) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
(In reply to Evelyn Hung [:evelyn] from comment #2) > Comment on attachment 8486250 [details] [review] > pull-request > > See comment on Github. Thanks. I agree, I'm locked to 'theme' however as that is how the icon is referred in the gaia-icons font. See Bug 1061133 and https://bugzilla.mozilla.org/show_bug.cgi?id=1064709. We could of course kindly ask Wilson to change that.
Flags: needinfo?(ehung)
|
|
||
Comment 4•10 years ago
|
||
I see you left a comment to Wilson on his patch, thanks! I'm fine with both, just a nit. :)
Flags: needinfo?(ehung)
|
|
Reporter | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 5•10 years ago
|
||
Marked as invalid as it's already been fixed: https://github.com/mozilla-b2g/gaia/commit/52fcd84499f7a23b2a0828bc6780f4a4625960df
You need to log in
before you can comment on or make changes to this bug.
Description
•