Closed
Bug 1064735
Opened 10 years ago
Closed 10 years ago
Theme apps should be hidden on homescreen
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S5 (26sep)
People
(Reporter: olle.klang, Assigned: olle.klang)
References
Details
Attachments
(2 files)
|
46 bytes,
text/x-github-pull-request
|
vingtetun
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
|
2.37 MB,
video/3gpp
|
Details |
Gaia themes (see Bug 1011738) are contained within a theme app. A theme app is not used for anything else and a user cannot interact with it. Hence, it should be hidden on the homescreen.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8486277 -
Flags: review?(21)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8486277 [details] [review] pull-request Looks good to me :)
Attachment #8486277 -
Flags: review?(21) → review+
|
|
||
Comment 3•10 years ago
|
||
(In reply to Olle Klang from comment #1) > Created attachment 8486277 [details] [review] > pull-request Can you fix the commit message to be: "Bug 1064735 - Theme apps should be hidden on homescreen. r=21" then I can merged it. (please needinfo'ed me after that so I won't forgot it).
|
|
Assignee | |
Comment 4•10 years ago
|
||
(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #3) > (In reply to Olle Klang from comment #1) > > Created attachment 8486277 [details] [review] > > pull-request > > Can you fix the commit message to be: "Bug 1064735 - Theme apps should be > hidden on homescreen. r=21" then I can merged it. (please needinfo'ed me > after that so I won't forgot it). It's changed :)
Flags: needinfo?(21)
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/12623e07c3396372a95a5b2fef50032529a2a4c9
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
|
|
||
Comment 6•10 years ago
|
||
(In reply to Olle Klang from comment #4) > (In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, > needinfo? please) from comment #3) > > (In reply to Olle Klang from comment #1) > > > Created attachment 8486277 [details] [review] > > > pull-request > > > > Can you fix the commit message to be: "Bug 1064735 - Theme apps should be > > hidden on homescreen. r=21" then I can merged it. (please needinfo'ed me > > after that so I won't forgot it). > > It's changed :) Seems like it has landed. Thanks.
Flags: needinfo?(21)
|
||
Updated•10 years ago
|
Attachment #8486277 -
Flags: approval-gaia-v2.1+
|
||
Comment 7•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/dcbd7ddb43b31a43819e62c2569908b66aa41bad
Assignee: nobody → olle.klang
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
Target Milestone: 2.1 S4 (12sep) → 2.1 S5 (26sep)
|
||
Comment 9•10 years ago
|
||
This issue has been successfully verified on Flame 2.1, 2.2 See attachment:verifyflame21.3gp Reproducing rate: 0/5 FLame2.1 new build: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141201001201 Version 34.0 Flame 2.2: Gaia-Rev 39214fb22c203e8849aaa1c27b773eeb73212921 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/08be3008650f Build-ID 20141201040205 Version 37.0a1
|
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•