1064743 - Transport fails after simultaneous sends

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

We are most likely mixing upload and some other request done while connecting.
No particular exception appears on client/server.
We should probably busify the UI until requests done on startup are done.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Wait for all requests to be done on WebIDE connection before allowing any action

The protocol doesn't like mixing requests...
so just wait for webapps-store.js to be fully loaded before accepting actions.

I may feel slower but it will prevent random breakages!

https://tbpl.mozilla.org/?tree=Try&rev=cf6f82e8208e

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Hmm, what's the STR to reproduce the issue you are seeing?  Do I need some of your auto-connect patches from bug 1055279?

Comment 3

[Alexandre Poirot [:ochameau]]

- Open a local app
- Connect to a device
- and right after selecting the device, try to push a local app [play button]

(in my case it was an app with a significant size - https://github.com/nazar-pc/CleverStyle-Music).

You will see WebIDE disconnecting while uploading the app.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In fact, you've found a bug in the transport!

It failed to correctly support the case of:

transport.send(...)
transport.startBulkSend(...)

in the same tick of the event loop.

I am somewhat surprised we've only noticed this until now...

Patch coming.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Support simultaneous sends in the transport

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ede4a45fa6a5

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8486756 [details] [diff] [review]
Support simultaneous sends in the transport

Review of attachment 8486756 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/a815df441343

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a815df441343