1064774 - Can't disconnect when opening debugger on an app with unavailable source map files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Developer Tools, defect)

Description

[Alexandre Poirot [:ochameau]]

The protocol breaks when we try to debug https://github.com/nazar-pc/CleverStyle-Music
Once I open the debugger, I can't disconnect the runtime (and most likely other requests may broke).

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Prevent script actor from breaking debugger protocol on unavailable resources.

It looks like an unhandled exception in this function breaks the protocol,
whereas rejecting the promise just print exceptions.
So let's reject the promise with a helpful error message...

https://tbpl.mozilla.org/?tree=Try&rev=7a165d8d92aa

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/1b976338e9bd

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b976338e9bd

Comment 4

[Francis Lee [:frlee]]

hi Carsten,

since this is landed one month ago, i just want to double confirm with you if this fix is in our current 2.1 branch? (i supposed it should be already in our current 2.1 branch)

thank you very much

Comment 5

[Carsten Book [:Tomcat]]

Hi Francis,

It landed on 35, which is v2.2 for 2.1 it needs a b2g34 approval request. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing#Landing_Procedure_5

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Alex, is this fix needed in 2.1?

Comment 7

[Alexandre Poirot [:ochameau]]

This isn't a regression. It is just broken on all branches.
So if we consider this bug to be important for 2.1 for need to ask for its uplift.

Comment 8

[Alexandre Poirot [:ochameau]]

Comment on attachment 8486312 [details] [diff] [review]
Prevent script actor from breaking debugger protocol on unavailable resources.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): not a regression, has always been broken
User impact if declined: some apps have broken debugging experience
Testing completed: lives on trunk for quite a bit now
Risk to taking this patch (and alternatives if risky): very low, just ignore an exception 
String or UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/a47adda8dd62