Closed Bug 1064774 Opened 7 years ago Closed 7 years ago
Can't disconnect when opening debugger on an app with unavailable source map files
The protocol breaks when we try to debug https://github.com/nazar-pc/CleverStyle-Music Once I open the debugger, I can't disconnect the runtime (and most likely other requests may broke).
It looks like an unhandled exception in this function breaks the protocol, whereas rejecting the promise just print exceptions. So let's reject the promise with a helpful error message... https://tbpl.mozilla.org/?tree=Try&rev=7a165d8d92aa
Attachment #8486312 - Flags: review?(past)
Attachment #8486312 - Flags: review?(past) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
hi Carsten, since this is landed one month ago, i just want to double confirm with you if this fix is in our current 2.1 branch? (i supposed it should be already in our current 2.1 branch) thank you very much
Hi Francis, It landed on 35, which is v2.2 for 2.1 it needs a b2g34 approval request. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing#Landing_Procedure_5
Alex, is this fix needed in 2.1?
This isn't a regression. It is just broken on all branches. So if we consider this bug to be important for 2.1 for need to ask for its uplift.
Component: Developer Tools: WebIDE → Developer Tools
Product: Firefox → Firefox OS
Target Milestone: Firefox 35 → ---
Comment on attachment 8486312 [details] [diff] [review] Prevent script actor from breaking debugger protocol on unavailable resources. NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): not a regression, has always been broken User impact if declined: some apps have broken debugging experience Testing completed: lives on trunk for quite a bit now Risk to taking this patch (and alternatives if risky): very low, just ignore an exception String or UUID changes made by this patch: none
Attachment #8486312 - Flags: approval-mozilla-b2g34?
Attachment #8486312 - Flags: approval-mozilla-b2g34? → approval-mozilla-b2g34+
You need to log in before you can comment on or make changes to this bug.