Closed Bug 1064807 Opened 10 years ago Closed 10 years ago

In multicall the sound alert for new SMS does not beep

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: lolimartinezcr, Assigned: davidg)

References

Details

Attachments

(1 file)

patch
46 bytes, text/x-github-pull-request
etienne
: review+
bajaj
: approval-gaia-v2.1+
Details | Review 
Flame
2.1
Gecko-f816f7e
Gaia-c7b55ed

Reproducible: 100%

Pre-requisites: Multicall established.

STR:
Receive a new message in mobile with multicall established.

Actual result:
New SMS does not beep

Expected result:
New SMS beeps
Assignee: nobody → david.garciaparedes
Status: NEW → ASSIGNED
Attached file patch — 
It wasn't checking if there was a connected multicall, because multicalls are inside telephony.conferenceGroup.calls instead of telephony.calls.
This should fix it.
Attachment #8486404 - Flags: review?(etienne)
Comment on attachment 8486404 [details] [review]
patch

r=me if we check the `state` on the conferenceGroup directly (and update the test accordingly)
Attachment #8486404 - Flags: review?(etienne) → review+
Blocks: 976678
https://github.com/mozilla-b2g/gaia/commit/7457a1c855394e6543fd2785644ec745367ad3f6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8486404 [details] [review]
patch

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 976678
[User impact] if declined: Notifications will not sound when in the middle of a multicall
[Testing completed]: Unit tests added
[Risk to taking this patch] (and alternatives if risky):
[String changes made]: no
Attachment #8486404 - Flags: approval-gaia-v2.1?
Attachment #8486404 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Tested and working
2.2
Flame
Gecko-713c41b
Gaia-32d82d2
Component: Gaia::SMS → Gaia::System
Tested and working
2.1
Gecko: 3953700
Gaia: 713448b
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: