1064832 - [gaiaconv] allow for empty {"locales":{"en-US":{}}} entries in manifest.webapp

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Axel Hecht [:Pike]]

Attachment: make both name and description optional. also, tests.

In bug 1022767, we want to use the manifest.webapp "locales" dict to denote which languages are supported by the web app.

But in particular for system apps, that name isn't ever used anywhere, which is a metric ton of wasted time for localizers and testers.

Thus, let's support that that dict is empty.

Stas, does this make sense to you? The test builds out https://bitbucket.org/pike/gaiaconv/src/525b654ceb3d43f5e09caf0b93dcf5555109576f/tests/test-gaia-conv.t, those tests just work by executing the stuff that looks like commands, and make sure the output is the same.

Comment 1

[Staś Małolepszy :stas]

Comment on attachment 8486376 [details] [diff] [review]
make both name and description optional. also, tests.

Review of attachment 8486376 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, f=me.  In the future, we should be able to avoid empty dicts thanks to https://github.com/w3c/manifest/issues/208.

Comment 2

[Axel Hecht [:Pike]]

https://bitbucket.org/pike/gaiaconv/commits/35080291cbd7533fbfd982e9b11d14179ea134ea, marking FIXED, thanks.