Closed Bug 1064845 Opened 10 years ago Closed 10 years ago

Use constants

Categories

(Hello (Loop) :: Server, defect)

Product:
Hello (Loop)
Component:
Server
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: tarek, Unassigned)

Details

(Whiteboard: [qa+])

Attachments

(1 file)

Link to Github PR — #200
56 bytes, text/x-github-pull-request
tarek
: review+
Details | Review 

        Attachment #8486476 -
        Flags: review?(tarek)
Whiteboard: [qa+]

    
  

        Attachment #8486476 -
        Flags: review?(tarek)

        Attachment #8486476 -
        Flags: review+

        Attachment #8486476 -
        Flags: feedback?(pdehaan)

    
    

    
  
All feedback left with love at https://github.com/mozilla-services/loop-server/pull/200
Let me know if you have any questions or want me to try re-grepping anything.

    
    

    
  
Thanks a lot Peter, I have updated the PR with your comments.

    
    

    
  
https://github.com/mozilla-services/loop-server/commit/0609a88ae2d54fbe3f3c0daa005cbffdb6f792cb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8486476 [details] [review]
Link to Github PR — #200

Removing obsolete feedback request - feedback was left as per comment 2.

        Attachment #8486476 -
        Flags: feedback?(pdehaan)

    
    

    
  
Went out with 0.12.0
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: