1064898 - Time picker is not displaying AM/PM for 12 hours format

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Francesco Lodolo [:flod]]

Both from Settings or FTU: either pick a language with 12 hours format, or choose 12 hours format in Date & Time, time picker won't display AM/PM anymore.

Gaia      3b76462c0377856d1b5cf454d12dde0ce8b768d4
Gecko     https://hg.mozilla.org/mozilla-central/rev/2255d7d187b2
BuildID   20140907160202
Version   35.0a1

Comment 1

[Francesco Lodolo [:flod]]

I think the problem is that the Time Picker is not reinitialized when time format is switched from 24hr to 12hr. 

1) Open the timepicker with 12h format, it looks like
2) Switch to 24h format, still ok
3) Switch back to 12h format, no AM/PM

Should be related to bug 1054135.

Comment 2

[[e-mail]]

I can reproduce it in 9/10 master. 

STR: (while lang = english)

1) open ui test > UI > select, press time field. The time popup shows 12h format.
2) open settings > Date & Time panel, Switch to 24h format
2.1) change to ui test app,  press time field. The time popup shows 24h format. (OK)
3) change to settings > Date & Time panel, Switch to 12h format
3.1) change to ui test app,  press time field. The time popup shows 12h format but without AM/PM. (fail)

expect

3.1) change to ui test app,  press time field. The time popup shows 12h format with AM/PM. (ok)

Comment 3

[[e-mail]]

[Blocking Requested - why for this release]:

New STR shows it is reproducible when language default is 24hr format (ex: french)

STR: (while lang = french, default 24hr format)

1) open ui test > UI > select, press time field. The time popup shows 24h format.
2) change to ui test app,  press time field. The time popup shows 24h format. (OK)
3) open settings > Date & Time panel, Switch to 12h format
4) change to ui test app,  press time field. The time popup shows 12h format but without AM/PM. (fail)

Comment 4

[Jason Smith [:jsmith]]

QA Wanted for branch checks (pretty sure it's a regression)

Comment 5

[Dietrich Ayala (:dietrich)]

Blocking because pretty sure this is a regression. If branch checks show it's not, renom please.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

This issue is reproducible on Flame 2.2 Master, Flame 2.1, and Open C 2.2 Master.

Observed behavior: Following STR at comment 2, timepicker UI no longer displays the AM/PM column for 12-hour format.

Device: Flame 2.2 Master
BuildID: 20140917212258
Gaia: d37950eb09e28aa18d0e01df9ff90574bd4337e0
Gecko: 426497473505
Version: 35.0a1 (2.2 Master)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20140918073020
Gaia: 379e68fe729a684fa2fcddb30ea1e65508db73e1
Gecko: 44eec4673c25
Version: 34.0a2 (2.1)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Open_C 2.2 Master
BuildID: 20140917212258
Gaia: d37950eb09e28aa18d0e01df9ff90574bd4337e0
Gecko: 426497473505
Version: 35.0a1 (2.2 Master)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

------------------

This issue is NOT reproducible on Flame 2.0 because the feature to change display hour format is NOT available in 2.0.

Device: Flame 2.0
BuildID: 20140918082321
Gaia: 31434a3949556171f3565ca47ac2b44e810e95e6
Gecko: 5cf783171d5c
Version: 32.0 (2.0)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 7

[Joshua Mitchell (Inactive)]

Tests indicate that this in NOT a regression. The feature to change display hour format was not introduced until 2.1 and testing the oldest 2.1 build we have repros the bug so it seems this feature was implemented with this bug.

--------------------------------------------------------------
Repro's on oldest 2.1

Device: Flame 2.1
BuildID: 20140904062538
Gaia: a47ecb6368c015dd72148acde26413fd90ba3136
Gecko: ffb144a500a4
Version: 34.0a2 (2.1)
Firmware: V165
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 8

[Dietrich Ayala (:dietrich)]

[Blocking Requested - why for this release]: Back to a nom then. Thanks for checking!

Comment 9

[[e-mail]]

Attachment: pull request redirect to github

The root cause is we did not clean previous hourformat styles for time picker

Comment 10

[howie [:howie]]

Triage: blocking

Comment 11

[howie [:howie]]

Triage: regression or not, time picker should show the correct format.

Comment 12

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/508af18b191c25181533299929c790aeb74437d7

thanks!

Comment 13

[[e-mail]]

Comment on attachment 8491990 [details] [review]
pull request redirect to github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature bug 1054135
[User impact] if declined: AM/PM shows incorrectly when language is changed
[Testing completed]: TBPL pass
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: None

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/b7c9c6785093b172ef3234744599e536c83de68c

Comment 15

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue is verified fixed on Flame 2.1(319mb)(KK)(Full Flash) and Flame 2.2(319mb)(KK)(Full Flash)

AM and PM is always shown on the 12h time picker after changing back and forth between 24h and 12h formats. 

Flame 2.1 

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2 

lame 2.2 Master  KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0