1064935 - Alias jschar to char16_t for ctypes in add-ons

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In the dev-platform thread announcing jschar's removal, cpeterson mentions it might be possible to keep an alias for add-ons:

"This change also affects js-ctypes and the Add-on SDK. JS code (outside mozilla-central) using `ctypes.jschar` will need to be replaced with `ctypes.char16_t`. If this is too much of a compatibility problem for add-ons, we could keep ctypes.jschar as an alias for ctypes.char16_t."

Filing this to discuss adding such an alias.  A search of known addons gives 388 matching lines in 108 files.

Additionally, all of the B2G simulator add-ons that the DevTools team manages are broken by this change and would need to be rebuilt, which at the moment accounts for at least 16 addons (platforms * versions) to rebuild, test, and release.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8486526 [details] [diff] [review]
patch v1

I've verified that this patch allows the simulators to start successfully.

Chris, what do you think about this?  I'd love to prevent them all from breaking in tomorrow's Nightly if we can.

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 8486526 [details] [diff] [review]
patch v1

Review of attachment 8486526 [details] [diff] [review]:
-----------------------------------------------------------------

LGMT. Thanks!

Comment 4

[Alexandre Poirot [:ochameau]]

https://tbpl.mozilla.org/?tree=Try&rev=d3fe272f30d9

I don't know where we are at with today and tomorrow nightlies,
but we would like to prevent releasing bug 1063962 without this patch.
(to prevent breaking addons on nightly)

So it may help to land directly on m-c ?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Once I see some green on that Try run, I can make sure it gets on to m-c before the next round of nightlies.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94342d2b81e6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/94342d2b81e6